Skip to content

Allow windows to continue on cache restore error#2536

Draft
jamesmunns wants to merge 1 commit into
masterfrom
james/cache-me-maybe
Draft

Allow windows to continue on cache restore error#2536
jamesmunns wants to merge 1 commit into
masterfrom
james/cache-me-maybe

Conversation

@jamesmunns
Copy link
Copy Markdown
Contributor

Mitigation for #2535

@jamesmunns jamesmunns requested review from emilyalbini and hawkw May 27, 2026 14:18
@jamesmunns jamesmunns changed the title Allow windows continue on cache restore error Allow windows to continue on cache restore error May 27, 2026
@jamesmunns
Copy link
Copy Markdown
Contributor Author

One tricky thing about this approach is that I don't know how we'd be able to determine if this mitigation is REALLY working or not (as the issue is intermittent!), short of looking at "builds that took a bit longer" in the actions history.

We'll definitely know if it doesn't work, as we'll still see CI failures on Windows.

Copy link
Copy Markdown
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think this is better than not having it, even though I agree that it's gonna be kinda hard to tell if it's working..

@emilyalbini
Copy link
Copy Markdown
Member

Before merging this I'd rather enable debug logging in all workflows. If we merge this too it's going to be harder to notice when it fails (and when to grab the logs).

@jamesmunns jamesmunns marked this pull request as draft May 28, 2026 11:35
@jamesmunns
Copy link
Copy Markdown
Contributor Author

Converting to draft so we remember that we might not want to merge this until we've had time to debug this. See #2540 for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants