Publish SP releases with Brussels#2387
Conversation
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
very minor comments questions but LGTM
|
|
||
| - name: Publish the release | ||
| uses: softprops/action-gh-release@v1 | ||
| uses: softprops/action-gh-release@v2 |
There was a problem hiding this comment.
What's the difference from v1 to v2?
There was a problem hiding this comment.
It makes it work with immutable releases.
In v1, the action would create the release in a published state and then add artifacts to it, which breaks once immutable releases are enabled. v2 uses the correct behavior of creating the release in a draft state, adding artifacts to it, and then marking the release as published (turning it immutable).
|
|
||
| #[derive(Debug, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| struct Bundle { |
There was a problem hiding this comment.
Guessing none of these are in a crate we can easily use?
There was a problem hiding this comment.
All of the crates defining the types I'm aware of (including my sigstore-verify crate) also bring in a bunch of crypto dependencies to do the actual sigstore validation, which would needlessly slow down xtask
emilyalbini
force-pushed
the
ea-brussels-next
branch
from
d17dd04 to
ff8cd11
Compare
emilyalbini
force-pushed
the
ea-brussels-next
branch
from
ff8cd11 to
696f83f
Compare
This PR changes the Hubris release process to rely on Brussels to create the GitHub release. **Using the sprot-release tool is still needed for now**, as I haven't integrated Brussels with the Omicron releng tooling (that's my next task). We can still start using the Brussels logic for creating the release. Most of the changes are actually in oxidecomputer/brussels#8, this just hooks things up in Hubris. I tested the release workflow on my test repo yesterday and it seemed to work, so hopefully this won't cause much breakage.
2 participants
This PR changes the Hubris release process to rely on Brussels to create the GitHub release. Using the sprot-release tool is still needed for now, as I haven't integrated Brussels with the Omicron releng tooling (that's my next task). We can still start using the Brussels logic for creating the release.
Most of the changes are actually in oxidecomputer/brussels#8, this just hooks things up in Hubris. I tested the release workflow on my test repo yesterday and it seemed to work, so hopefully this won't cause much breakage.