Skip to content

Vertically centre radio and checkbox with label #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjaminleonard wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Vertically centre radio and checkbox with label #3049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d02e303
Vertically centre radio and checkbox properly
benjaminleonard Feb 6, 2026
3ff3ceb
Remove unneeded class
benjaminleonard Feb 6, 2026
c272dd1
Revert "Vertically centre radio and checkbox properly"
benjaminleonard Feb 6, 2026
57d1d49
Try extra clever version
benjaminleonard Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/access-util.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export function RoleRadioField<
className="mt-2"
>
{R.reverse(allRoles).map((role) => (
<Radio name="roleName" key={role} value={role} alignTop>
<Radio name="roleName" key={role} value={role}>
<div className="text-sans-md text-raise">
{capitalize(role).replace('_', ' ')}
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/ui/lib/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ export const Checkbox = ({
className,
...inputProps
}: CheckboxProps) => (
<label className="items-top inline-flex">
<span className="relative h-4 w-4">
<label className="text-sans-md items-top inline-flex">
<span className="relative mt-[calc((1lh-16px)/2)] h-4 w-4">
<input
className={cn(inputStyle, className)}
type="checkbox"
Expand Down
13 changes: 5 additions & 8 deletions app/ui/lib/Radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ import cn from 'classnames'
import type { ComponentProps } from 'react'

// input type is fixed to "radio"
export type RadioProps = Omit<React.ComponentProps<'input'>, 'type'> & {
/** Align radio button with top of content instead of center (useful for multi-line content) */
alignTop?: boolean
}
export type RadioProps = Omit<React.ComponentProps<'input'>, 'type'>

const fieldStyles = `
peer appearance-none absolute outline-hidden
Expand All @@ -29,15 +26,15 @@ const fieldStyles = `
disabled:hover:bg-transparent
`

export const Radio = ({ children, className, alignTop, ...inputProps }: RadioProps) => (
<label className={cn('inline-flex', alignTop ? 'items-start' : 'items-center')}>
<span className="relative h-4 w-4 shrink-0">
export const Radio = ({ children, className, ...inputProps }: RadioProps) => (
<label className="text-sans-md inline-flex items-start">
<span className="relative mt-[calc((1lh-16px)/2)] h-4 w-4 shrink-0">
<input className={cn(fieldStyles, className)} type="radio" {...inputProps} />
{/* the dot in the middle. hide by default, use peer-checked to show if checked */}
<div className="bg-accent pointer-events-none absolute top-1 left-1 hidden h-2 w-2 rounded-full peer-checked:block" />
</span>

{children && <span className="text-sans-md text-default ml-2.5">{children}</span>}
{children && <span className="text-default ml-2.5">{children}</span>}
</label>
)

Expand Down
Loading