Skip to content

fix(draw-io): make applicationConfig prop optional to fix lint warning#323

Closed
mmattel wants to merge 1 commit intomainfrom
drawio_linter_fix
Closed

fix(draw-io): make applicationConfig prop optional to fix lint warning#323
mmattel wants to merge 1 commit intomainfrom
drawio_linter_fix

Conversation

@mmattel
Copy link
Copy Markdown
Contributor

@mmattel mmattel commented Feb 8, 2026

References: #322 (fix(draw-io): make applicationConfig prop optional)

The prop has a default value, so it should not be marked as required. Fixes: vue/no-required-prop-with-default

@LukasHirt pls double check if this fixes the issue correctly

Attempt to fix the linter warning:

+ pnpm lint

> web-extensions@ lint /drone/src
> eslint '{packages,support}/**/*.{js,ts,vue}' '*.{ts,js}' --color


/drone/src/packages/web-app-draw-io/src/App.vue
  34:5  warning  Prop "applicationConfig" should be optional  vue/no-required-prop-with-default

✖ 1 problem (0 errors, 1 warning)

The prop has a default value, so it should not be marked as required.
Fixes: vue/no-required-prop-with-default

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mmattel mmattel requested a review from LukasHirt February 8, 2026 15:41
@mmattel mmattel added the bug Something isn't working label Feb 8, 2026
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice the previous comment in the code. According to it, the correct solution would be to remove the default value instead. Which probably entails some deeper issue given the workaround.

@mmattel
Copy link
Copy Markdown
Contributor Author

mmattel commented Mar 2, 2026

Closing because the referenced PR got closed

@mmattel mmattel closed this Mar 2, 2026
@mmattel mmattel deleted the drawio_linter_fix branch March 2, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants