Skip to content

feat: publish a signed release on tag push #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeepDiver1975 merged 1 commit into from
Jul 28, 2026
Merged

feat: publish a signed release on tag push #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Release

on:
push:
tags:
- 'v*'

permissions:
contents: read

jobs:
release:
permissions:
contents: write
uses: owncloud/reusable-workflows/.github/workflows/release.yml@main
with:
app-name: notes
# notes emits two tarballs both named notes.tar.gz (source and appstore);
# publish only the appstore one, otherwise the release assets collide.
artifact-glob: build/artifacts/appstore/*.tar.gz
secrets:
SIGNING_KEY: ${{ secrets.SIGNING_KEY }}
SIGNING_CERT: ${{ secrets.SIGNING_CERT }}
SIGNING_CHAIN: ${{ secrets.SIGNING_CHAIN }}
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ endif
# * the certificate is located in ~/.owncloud/notes.crt
occ=$(CURDIR)/../../occ
phpunit_oc10=$(CURDIR)/../../lib/composer/bin/phpunit
configdir=$(CURDIR)/../../config
private_key=$(HOME)/.owncloud/certificates/$(app_name).key
certificate=$(HOME)/.owncloud/certificates/$(app_name).crt
sign=php -f $(occ) integrity:sign-app --privateKey="$(private_key)" --certificate="$(certificate)"
Expand Down Expand Up @@ -168,9 +167,7 @@ appstore: build
"CHANGELOG.md" \
$(appstore_build_directory)
ifdef CAN_SIGN
mv $(configdir)/config.php $(configdir)/config-2.php
$(sign) --path="$(appstore_build_directory)"
mv $(configdir)/config-2.php $(configdir)/config.php
else
@echo $(sign_skip_msg)
endif
Expand Down