fix: remove Oracle/OCI support from installer and setup#41555
Merged
Conversation
Oracle is no longer a supported database. Remove the --database-connection-string option from maintenance:install, drop OCI from the setup class registry and supported databases list, clean up the web installer template and JS, and update the SetupTest assertions accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Oracle is no longer supported, so the setup class used during installation is no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
- Drop dbconnectionstring and dbConnectionString from AbstractDatabase - Remove dbtablespace default from SetupController - Remove oci from DBCONFIGS, Oracle docker spin-up, and oci notes in autotest.sh and autotest-external.sh - Remove plugin_wait_for_oracle(), oracle) case, and --database-connection-string branch from install-server.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
approved these changes
May 20, 2026
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Looks reasonable, they are all Oracle things that are deleted.
jvillafanez
approved these changes
May 20, 2026
Member
|
There is still some code related to oracle in multiple places that we should remove sooner than later. We probably need to come up with a removal strategy if we don't want to wipe it in one go. |
Member
Author
absolutly true - for the time being we keep other code elements .... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--database-connection-stringoption and all OCI-specific logic frommaintenance:installcommandocifrom the supported databases list,$dbSetupClasses, andgetSystemInfo()inSetup.phpOC\Setup\OCIclass entirelySetupTestassertions to reflect Oracle's removalCloses #41554
Test plan
php occ maintenance:install --helpand confirm--database-connection-stringandociare gonetests/lib/SetupTest.phpin CI to confirm updated assertions pass🤖 Generated with Claude Code