Deprecate legacy OC_DB class and replace its usages by DeepDiver1975 · Pull Request #41455 · owncloud/core

DeepDiver1975 · 2026-02-18T23:41:06Z

Marked class OC_DB as deprecated and replaced its usage in the codebase with modern IDBConnection methods. Updated Trashbin, User, Group, Share, Setup, and Installer components. Adjusted unit tests to use the new database connection patterns.

PR created automatically by Jules for task 5239319852108041845 started by @DeepDiver1975

google-labs-jules · 2026-02-18T23:41:08Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

update-docs · 2026-02-18T23:41:10Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

CLAassistant · 2026-02-18T23:50:08Z

All committers have signed the CLA.

DeepDiver1975 · 2026-02-19T09:56:32Z

PHP code style has issues

1) lib/private/Share/Share.php (class_definition, method_argument_space, braces_position)
      ---------- begin diff ----------
--- /home/runner/work/core/core/lib/private/Share/Share.php
+++ /home/runner/work/core/core/lib/private/Share/Share.php
@@ -205,7 +205,7 @@
 				`*PREFIX*share`
 				WHERE
 				`item_source` = ? AND `share_type` IN (?, ?) AND `item_type` IN (\'file\', \'folder\')',
-				[$source, self::SHARE_TYPE_USER, self::$shareTypeGroupUserUnique]
+					[$source, self::SHARE_TYPE_USER, self::$shareTypeGroupUserUnique]
 				);
 			}
 
@@ -1221,7 +1221,8 @@
 
 		if (!$itemUnshared && isset($groupShare) && !isset($uniqueGroupShare)) {
 			$connection = \OC::$server->getDatabaseConnection();
-			$connection->executeStatement('INSERT INTO `*PREFIX*share`'
+			$connection->executeStatement(
+				'INSERT INTO `*PREFIX*share`'
 				.' (`item_type`, `item_source`, `item_target`, `parent`, `share_type`,'
 				.' `share_with`, `uid_owner`, `permissions`, `stime`, `file_source`, `file_target`)'
 				.' VALUES (?,?,?,?,?,?,?,?,?,?,?)',
@@ -1228,7 +1229,8 @@
 				[$groupShare['item_type'], $groupShare['item_source'], $groupShare['item_target'],
 				$groupShare['id'], self::$shareTypeGroupUserUnique,
 				\OC_User::getUser(), $groupShare['uid_owner'], 0, $groupShare['stime'], $groupShare['file_source'],
-				$groupShare['file_target']]);
+				$groupShare['file_target']]
+			);
 			$shareTmp = [
 				'id' => $groupShare['id'],
 				'shareWith' => $groupShare['share_with'],


Detected deprecations in use (they will stop working in next major release):
- Rule "visibility_required" is deprecated. Use "modifier_keywords" instead.
      ----------- end diff -----------

This commit drops the `OC_DB` class. Occurrences of `OC_DB` and `OCP\DB` throughout the codebase have been replaced with modern `IDBConnection` methods retrieved via `\OC::$server->getDatabaseConnection()`. Key changes: - Updated `Trashbin`, `User`, `Group`, `Share`, `Installer`, `Setup`, and `Repair` components to use `executeQuery` and `executeStatement`. - Replaced `fetchRow()` with `fetch()` and `fetchOne()` with `fetchColumn()`. - Updated `createDbFromStructure` and `updateDbFromStructure` calls to use `MDB2SchemaManager` directly. - Modernized several unit tests to reflect these changes.

jvillafanez

Assuming tests pass

jvillafanez · 2026-02-20T09:54:33Z

apps/files_trashbin/lib/Trashbin.php

+			. ' FROM `*PREFIX*files_trash` WHERE `user`=?', [$user]);
 		$array = [];
-		while ($row = $result->fetchRow()) {
+		while ($row = $result->fetch()) {


Side note, I've found the following in the dbal upgrade notes for 4.0:

## BC BREAK: Remove legacy execute and fetch methods. The following methods have been removed: * `Result::fetch()` * `Result::fetchAll()` * `Connection::exec()` * `Connection::executeUpdate()` * `Connection::query()` Additionally, the `FetchMode` class has been removed.

For the upgrade to 3.0, this might be relevant:

## Removed `FetchMode` and the corresponding methods 1. The `FetchMode` class and the `setFetchMode()` method of the `Connection` and `Statement` interfaces are removed. 2. The `Statement::fetch()` method is replaced with `fetchNumeric()`, `fetchAssociative()` and `fetchOne()`. 3. The `Statement::fetchAll()` method is replaced with `fetchAllNumeric()`, `fetchAllAssociative()` and `fetchColumn()`. 4. The `Statement::fetchColumn()` method is replaced with `fetchOne()`. 5. The `Connection::fetchArray()` and `fetchAssoc()` methods are replaced with `fetchNumeric()` and `fetchAssociative()` respectively. 6. The `StatementIterator` class is removed. The usage of a `Statement` object as `Traversable` is no longer possible. Use `iterateNumeric()`, `iterateAssociative()` and `iterateColumn()` instead. 7. Fetching data in mixed mode (former `FetchMode::MIXED`) is no longer possible.

I think we'll need to make additional changes sooner than later.

jvillafanez · 2026-02-20T10:01:50Z

lib/private/AppFramework/Db/Db.php

+	 */
+	private function isManipulation($sql) {
+		$selectOccurrence = \stripos($sql, 'SELECT');
+		if ($selectOccurrence !== false && $selectOccurrence < 10) {


The selectOccurrence < 10 needs a comment. It seems a magic number so far.
Since this was moved from another place, I guess it's fine...

We hopefully can kill this OC_DB_StatementWrapper then the whole logic is gone

DeepDiver1975 force-pushed the deprecate-oc-db-and-replace-usage-5239319852108041845 branch 3 times, most recently from 1bf2476 to 1c028aa Compare February 20, 2026 09:27

DeepDiver1975 force-pushed the deprecate-oc-db-and-replace-usage-5239319852108041845 branch from 1c028aa to 5770d98 Compare February 20, 2026 09:34

jvillafanez approved these changes Feb 20, 2026

View reviewed changes

DeepDiver1975 merged commit 0b0db02 into master Feb 20, 2026
7 checks passed

DeepDiver1975 deleted the deprecate-oc-db-and-replace-usage-5239319852108041845 branch February 20, 2026 10:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate legacy OC_DB class and replace its usages#41455

Deprecate legacy OC_DB class and replace its usages#41455
DeepDiver1975 merged 1 commit intomasterfrom
deprecate-oc-db-and-replace-usage-5239319852108041845

DeepDiver1975 commented Feb 18, 2026

Uh oh!

google-labs-jules bot commented Feb 18, 2026

Uh oh!

update-docs bot commented Feb 18, 2026

Uh oh!

CLAassistant commented Feb 18, 2026 •

edited

Loading

Uh oh!

DeepDiver1975 commented Feb 19, 2026

Uh oh!

jvillafanez left a comment

Uh oh!

jvillafanez Feb 20, 2026

Uh oh!

DeepDiver1975 Feb 20, 2026

Uh oh!

jvillafanez Feb 20, 2026

Uh oh!

DeepDiver1975 Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

DeepDiver1975 commented Feb 18, 2026

Uh oh!

google-labs-jules bot commented Feb 18, 2026

Uh oh!

update-docs bot commented Feb 18, 2026

Uh oh!

CLAassistant commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeepDiver1975 commented Feb 19, 2026

Uh oh!

jvillafanez left a comment

Choose a reason for hiding this comment

Uh oh!

jvillafanez Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

jvillafanez Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

CLAassistant commented Feb 18, 2026 •

edited

Loading