Finish Doctrine DBAL 3.x migration#41454
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
from
f307e61 to
a8fe522
Compare
|
rebase |
Acknowledged. I'm resubmitting the changes to ensure everything is up to date. |
DeepDiver1975
force-pushed
the
finish-dbal-3-migration-6256941112454037654
branch
2 times, most recently
from
bbbcc7b to
4db9e66
Compare
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
2 times, most recently
from
f88593d to
faaa0c8
Compare
- Updated IDBConnection, Connection, and OracleConnection with DBAL 3 type hints. - Replaced deprecated getSchemaManager() with createSchemaManager(). - Added executeQuery() and executeStatement() to IQueryBuilder and QueryBuilder. - Updated OC_DB_StatementWrapper for DBAL 3 Result compatibility. - Globally replaced fetchAssoc, fetchArray, fetchColumn, and executeUpdate with DBAL 3 equivalents. - Preserved Result::free() calls. - Ensured Symfony Console BufferedOutput::fetch() calls are not incorrectly replaced. - Updated lib/base.php to allow PHP versions up to 8.4.0. Co-authored-by: DeepDiver1975 <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
finish-dbal-3-migration-6256941112454037654
branch
from
4db9e66 to
4455487
Compare
2 participants
This PR completes the migration from Doctrine DBAL 2.x to 3.x.
Key changes include updating core database connection interfaces and classes, enhancing the QueryBuilder with new execution methods, and globally updating deprecated method calls throughout the codebase. Special care was taken to maintain compatibility with legacy components and ensure that non-database fetch() calls (like those in Symfony Console) remain untouched.
PR created automatically by Jules for task 6256941112454037654 started by @DeepDiver1975