Repository navigation
Conversation
read_request_body() calls ap_map_http_request_error(), which is a symbol of httpd itself (modules/http/http_filters.c), not of APR, so the standalone module (and the IIS/nginx flavours built on it) failed to link since that call was introduced. Builds that define VERSION_STANDALONE, VERSION_IIS or VERSION_NGINX now carry a local copy of the function, taken from httpd, under the same name through a macro so the call site stays identical for the Apache module. Fixes owasp-modsecurity#3451 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0181jBv5JdNQviwDzfnkf1Gy
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
apache2/apache2_io.cgets a local copy of httpd'sap_map_http_request_error()(frommodules/http/http_filters.c) for builds that defineVERSION_STANDALONE,VERSION_IISorVERSION_NGINX, exposed under the same name through a macro so the call site inread_request_body()stays unchanged for the Apache module.Why
ap_map_http_request_error()is a symbol of httpd itself, not of APR, so the standalone library (and everything built on it) carried an undefined reference since that call was introduced and could not be linked into a host program (#3451). This is @airween's patch from the issue thread; the macro choice follows his note:VERSION_STANDALONEis whatstandalone/Makefile.amactually defines, the other two are kept for the IIS and nginx flavours that reuse the same sources.Tests
Verified in a Debian bookworm container with
./configure --enable-standalone-module --disable-apache2-module:v2/master:nm -D standalone/.libs/standalone.soshowsU ap_map_http_request_error;msc_ap_map_http_request_erroris a local symbol.The Apache module build is unaffected (the block is compiled out).
References
Fixes #3451
🤖 Generated with Claude Code