fix: cppcheck warnings#3530
Merged
fzipi merged 2 commits intoowasp-modsecurity:v2/masterfrom Mar 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses cppcheck failures by reducing variable scope in the standalone Apache compatibility layer and adding an extra cppcheck suppression for APR headers.
Changes:
- Move loop/index variables in
ap_index_of_response()into narrower scopes to satisfycppcheckwarnings. - Update the
cppcheckMakefile target to add a suppression forsyntaxErrororiginating from APR system headers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
standalone/server.c |
Narrows variable scope in ap_index_of_response() to eliminate cppcheck warnings. |
Makefile.am |
Adjusts cppcheck invocation and adds an APR header suppression to reduce noise/failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
fzipi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cppcheck warning in standalone/server.c; add suppression to whole header's dir
what
This PR fixes some
cppcheckwarnings:I prefer this way (second item) because at this way we see the suppression, don't need top check the suppression's file.
why
There were some cppcheck warnings and failed tests in recent PR's.
references
#3527