Repository navigation
fix(export): stream batched SQLite table dumps via ReadableStream (#59) - #330
Closed
jeffrey-graham wants to merge 1 commit into
Closed
jeffrey-graham wants to merge 1 commit into
jeffrey-graham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59
/claim #59
Problem
dumpDatabaseRouteinsrc/export/dump.tspreviously executedSELECT * FROM ${table};for every table and concatenated the entire SQL dump in memory into a singledumpContentstring before wrapping it innew Blob([dumpContent]). On large Cloudflare Durable Object SQLite databases, this exceeds Worker memory/response limits and fails.Solution
fetchRowsBatches(tableName, dataSource, config)async generator queryingSELECT * FROM ${tableName} LIMIT 1000 OFFSET ${offset};in batches ofROW_BATCH_SIZE = 1000.INSERT INTOstatements through aReadableStream<Uint8Array>directly intonew Response(stream, { headers })so memory usage remains bounded regardless of database size.