AO3-7120 Change user troubleshooting to also reindex user in admin user search#5484
AO3-7120 Change user troubleshooting to also reindex user in admin user search#5484Cubostar wants to merge 3 commits intootwcode:masterfrom
Conversation
sarken
left a comment
There was a problem hiding this comment.
The issue mentions this will rely on automated testing, not manual, so I'm going to mark this as Action Needed until automated tests are added.
|
Please also update the "To fix common errors with this user's Subscriptions and Stats pages..." note on the user administration page to mention the admin user search |
Bilka2
left a comment
There was a problem hiding this comment.
As I said in my previous comment, please update the troubleshooting help text on the admin user page. It should say
To fix common errors with this user's Subscriptions and Stats pages, and to reindex the user and their works and bookmarks, choose "Troubleshoot."
| @user.set_user_work_dates | ||
| @user.reindex_user_creations | ||
| @user.update_works_index_timestamp! | ||
| @user.reindex_document |
There was a problem hiding this comment.
please call enqueue_to_index instead, we don't need to do this reindexing synchronously and it matches what reindex_user_creations does. you can then check that it was queued with add_to_reindex_queue in the rspec test
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7120
Purpose
This PR makes the Troubleshoot button in the admin user also reindex the user.
Credit
Cubostar, he/him