Closed
Conversation
Collaborator
|
its good |
thehabes
reviewed
Mar 30, 2026
Collaborator
thehabes
left a comment
thehabes
left a comment
There was a problem hiding this comment.
I did not take this file into account earlier on in the project. It is specific proprietary functionality that only the RCG RERUM needs. I have made a new issue for consideration regarding these endpoints - #65
I did not formally review this code once I realized this file and the related endpoints should be removed. Apologies for my oversight
Collaborator
Author
|
Since GOG is no longer needed, this pull request will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
controllers/gog.jsfile for better code clarity and readability. Introduced shared constants (GOG_PRODUCTION_AGENT_ID, DEFAULT_LIMIT, DEFAULT_SKIP, JSON_CONTENT_TYPE) to replace hardcoded values. Also included two helper functionssetJsonResponseType(res)to standardize response headers andrunAggregation(pipeline)to encapsulate repeated MongoDB aggregation logic and error handling.