Skip to content

OSAC-3734: update required checks to E2E gate job names - #183

Merged
omer-vishlitzky merged 2 commits into
osac-project:mainfrom
omer-vishlitzky:fix/OSAC-3734-gate-check-names
Aug 9, 2026
Merged

OSAC-3734: update required checks to E2E gate job names#183
omer-vishlitzky merged 2 commits into
osac-project:mainfrom
omer-vishlitzky:fix/OSAC-3734-gate-check-names

Conversation

@omer-vishlitzky

@omer-vishlitzky omer-vishlitzky commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Update required status checks from reusable workflow job names to gate job names:

Before After
e2e-vmaas-full-install / e2e e2e-vmaas-gate
e2e-bmaas-full-install / e2e e2e-bmaas-gate
e2e-caas-full-install / e2e e2e-caas-gate

Why

The reusable workflow check (e2e-vmaas-full-install / e2e) only exists when E2E actually runs. Docs-only PRs skip E2E, so the check is never reported — merge queue blocks forever with "Expected — Waiting for status."

Gate jobs (osac#222) always run and report a result: pass for docs-only PRs (no E2E needed), pass/fail for code PRs (reflects E2E result).

Merge order

  1. osac#222 — rename gate jobs (must exist before this PR changes required checks)
  2. This PR — update required check names to match

Test plan

  • After both PRs merge: docs-only PRs show e2e-vmaas-gate as passed, can enter merge queue
  • Code PRs: gate jobs reflect actual E2E result

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated required status checks for VMAAS, BMAAS, and CAAS to use the appropriate end-to-end validation gates.

Update required status checks from reusable workflow job names
(e2e-vmaas-full-install / e2e) to gate job names (e2e-vmaas-gate).

Gate jobs always run and report a result — pass for docs-only PRs,
pass/fail for code PRs. The reusable workflow check only exists when
E2E actually runs, blocking docs-only PRs from entering the merge
queue.

Companion: osac-project/osac#222 (renames the gate jobs).
Merge osac#222 first, then this PR.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: omer-vishlitzky <omer.vishlitzky@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@omer-vishlitzky, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e7b79f2-9bda-458f-86d0-23e6767da6fb

📥 Commits

Reviewing files that changed from the base of the PR and between 737012e and 544c6d0.

📒 Files selected for processing (1)
  • repositories.tf

Walkthrough

Updated repo_osac required status checks to use the e2e-*-gate contexts for VMAAS, BMAAS, and CAAS instead of the full-install workflow contexts.

Changes

Required status checks

Layer / File(s) Summary
Update E2E gate checks
repositories.tf
Branch protection now requires e2e-vmaas-gate, e2e-bmaas-gate, and e2e-caas-gate.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: eliorerz, larsks

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the required status-check updates to E2E gate job names.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The only additions are three E2E gate context names with numeric integration IDs; secret-indicator searches found no keys, tokens, passwords, credentials, private keys, or credential URLs.
No-Weak-Crypto ✅ Passed The patch only replaces three Terraform status-check strings with e2e-* gate names; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto.
No-Injection-Vectors ✅ Passed The PR only replaces three quoted Terraform status-check literals; no SQL concatenation, shell/eval/exec, pickle/yaml loading, os.system, or dangerouslySetInnerHTML is present.
Container-Privileges ✅ Passed The commit changes only three Terraform status-check strings; scans found no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation declarations.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only three required-check context strings in repositories.tf; the diff adds no logging statements or sensitive data.
Ai-Attribution ✅ Passed Claude Code is disclosed, and the PR commit includes an Assisted-by: Claude Code trailer with no AI Co-Authored-By trailer.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eranco74

eranco74 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@omer-vishlitzky
omer-vishlitzky merged commit 6295c2d into osac-project:main Aug 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants