Skip to content

OSAC-3734: fix label-gate required check name - #182

Merged
omer-vishlitzky merged 1 commit into
osac-project:mainfrom
omer-vishlitzky:fix/OSAC-3734-check-name
Aug 9, 2026
Merged

OSAC-3734: fix label-gate required check name#182
omer-vishlitzky merged 1 commit into
osac-project:mainfrom
omer-vishlitzky:fix/OSAC-3734-check-name

Conversation

@omer-vishlitzky

@omer-vishlitzky omer-vishlitzky commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the required status check context for the label-gate workflow: check-labels instead of label-gate / check-labels.

The <workflow> / <job> naming format only applies to reusable workflow calls. Single-workflow jobs report just the job name. The current config causes the check to show as "Expected — Waiting for status to be reported" even though the workflow passes.

One-line change: repositories.tf line 152.

Test plan

  • After tofu apply: check-labels shows as satisfied (not "Expected") on PRs where label-gate passed

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated the required status check name to ensure repository validation uses the correct check.

The check-run name is `check-labels` (just the job name), not
`label-gate / check-labels`. The `workflow / job` prefix format
only applies to reusable workflow calls.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: omer-vishlitzky <omer.vishlitzky@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0139d6a2-0c75-4264-8201-b23abbafb649

📥 Commits

Reviewing files that changed from the base of the PR and between 83e6c8e and 5a4dde4.

📒 Files selected for processing (1)
  • repositories.tf

Walkthrough

The required repo_osac status check context changes from label-gate / check-labels to check-labels. The integration ID remains unchanged.

Changes

Status check update

Layer / File(s) Summary
Rename required status check context
repositories.tf
The repo_osac required status check uses the check-labels context. The integration ID remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: larsks, eliorerz

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the fix to the required label-gate check name, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The only change replaces one status-check context string in repositories.tf; it adds no API key, token, password, private key, credential, or other secret-shaped literal.
No-Weak-Crypto ✅ Passed The PR changes only a Terraform status-check string; repository scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
No-Injection-Vectors ✅ Passed The PR changes only one Terraform status-check string; no SQL concatenation, shell injection, eval/exec, unsafe deserialization, os.system, or dangerouslySetInnerHTML pattern is introduced.
Container-Privileges ✅ Passed The PR changes only a Terraform status-check context. No container/Kubernetes manifests or privilege settings such as privileged, host namespaces, SYS_ADMIN, root, or allowPrivilegeEscalation are p...
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only one Terraform status-check string; it adds no logging or output of passwords, tokens, API keys, PII, hostnames, or customer data.
Ai-Attribution ✅ Passed The PR mentions Claude Code and its commit includes an Assisted-by: Claude Code trailer; no AI Co-Authored-By trailer is present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eranco74 eranco74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@omer-vishlitzky
omer-vishlitzky merged commit b8f339a into osac-project:main Aug 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants