Skip to content

feat(cloud): make org invites shareable via HTTPS deep-link handoff - #552

Draft
beruro wants to merge 3 commits into
developfrom
junyu/deep-link-org-joining
Draft

feat(cloud): make org invites shareable via HTTPS deep-link handoff#552
beruro wants to merge 3 commits into
developfrom
junyu/deep-link-org-joining

Conversation

@beruro

@beruro beruro commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Problem

Custom-scheme organization invite links are awkward to share through Slack and social surfaces, and a second application instance may not forward deep links safely to the running ORG2 process.

Solution

  • Generate HTTPS handoff links while keeping the invite capability in the URL fragment.
  • Preserve direct orgii://cloud/join and legacy HTTPS query-link compatibility while rejecting foreign URLs.
  • Enable single-instance deep-link forwarding and restore or recreate the main window without logging capability-bearing argv.
  • Preserve the current develop two-card invite UI while updating it to HTTPS handoff semantics.
  • Validation: 71 focused Vitest tests, TypeScript typecheck, targeted ESLint, Rust check/rustfmt, diff check, handoff-site tests, and manual second-account acceptance.

Potential risks

  • The deployed HTTPS handoff site is an external runtime dependency: https://orgii-invite-link.atah2000.chatgpt.site/
  • Platform-specific single-instance and deep-link behavior still needs release-bundle coverage on macOS, Windows, and Linux.
  • Invite capabilities must never be logged or moved from the URL fragment into server-visible request data.

Verification

Published branch was rebased by GitHub onto current develop at 7be527a7a, producing head 488fc6503. The rebase completed without conflicts, and changed-file/addition/deletion counts are unchanged from the pre-rebase PR. CI is rerunning on this integrated head.

Previous GitHub CI on head cd9049794:

  • pnpm install --frozen-lockfilePASS in Frontend (typecheck · lint · test).
  • pnpm typecheckPASS in Frontend (typecheck · lint · test).
  • pnpm lintPASS in Frontend (typecheck · lint · test).
  • pnpm run testPASS in Frontend (typecheck · lint · test).
  • node scripts/tauri/prepare-sidecars.cjs --profile debugPASS in Rust (clippy).
  • (cd src-tauri && cargo clippy --workspace --all-targets -- -D warnings)PASS in Rust (clippy).
  • AI-attribution history scan — PASS.

Not run: release-bundle deep-link coverage on macOS, Windows, and Linux; this remains required before marking the PR merge-ready.

@beruro
beruro force-pushed the junyu/deep-link-org-joining branch 4 times, most recently from e5059f6 to 43d6529 Compare July 30, 2026 15:11
@Harry19081

Copy link
Copy Markdown
Member

@Neonforge98 Can you investigate how to deploy this?

@beruro
beruro marked this pull request as draft August 10, 2026 03:35
@beruro
beruro force-pushed the junyu/deep-link-org-joining branch from cd90497 to 3b1ad12 Compare August 10, 2026 04:05
@beruro
beruro force-pushed the junyu/deep-link-org-joining branch from 3b1ad12 to 488fc65 Compare August 10, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants