ci: build the workspace before packaging the VSIX - #248
Merged
Conversation
build-vscode stamped core's VERSION into packages/core/src/index.ts and went straight to packaging. The VSIX bundles the app-server, which bundles core, and core's package exports point at dist/ — so esbuild could not resolve @deepcode/core/skills, /tools, or /dist/providers/deepseek.js, and the stamped version would never have reached the bundle either. `pnpm release:check` has always built first, which is why the gate passes locally, and publish-cli already had the step. build-vscode was the one path that skipped it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third latent
release.ymlbug, uncovered once #247 gotbuild-vscodepast its version step.build-vscodestamps core'sVERSIONintopackages/core/src/index.ts, then goes straight to packaging. But the VSIX bundles the app-server, which bundles core, and core's packageexportspoint atdist/— which doesn't exist yet. Two consequences, not one: esbuild can't resolve the subpaths, and the version it just stamped would never have reached the bundle, since nothing compiled it.pnpm release:checkhas always beenpnpm build && …— which is why the gate passes locally and invalidate.publish-clialready has the step at line 134.build-vscodewas the one path that skipped it.Progress on the pipeline
bwrap ENOENT(#246)npm version+workspace:*(#247)Each fix moved the failure forward by one step, which is the expected shape when a pipeline has never run.
Test plan
pnpm release:checkpasses locally with the same build-then-package ordering this addspublish-clialready hadpnpm buildafter its stamp step — this makes the two jobs consistentRelease notes label
release-notes:internalRelated
Follows #246 and #247. Blocks the v0.3.0 release (#245).
🤖 Generated with Claude Code