fix: stablize flaky test in bmc-aispeech-realtime#728
Open
lycoris106 wants to merge 1 commit intooracle:masterfrom
Open
fix: stablize flaky test in bmc-aispeech-realtime#728lycoris106 wants to merge 1 commit intooracle:masterfrom
lycoris106 wants to merge 1 commit intooracle:masterfrom
Conversation
Signed-off-by: Chih-Fu Lai <lycoris1062@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
Thank you for signing the OCA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some flaky tests found with NonDex, which explores non-determinism in tests. These tests can fail under different JVMs, hash seeds, etc.
The flaky tests:
Root Cause
In the test
testOnConnectAndClose, the assertion assumes a fixed order of fields in the json string. However, JSON serialization depends on non-deterministic map iteration order and can placetestKeybefore or afteruri:Fix
We use a safer way to compare jsons, by parsing them into jackson's JsonNodes.
Failure Reproduction
Ubuntu 24.04.3 LTSBuild with the main branch and run tests with NonDex to observe the failure, for example:
Notes