[GR-71934] Run Python gates on Github #574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Ariouz
force-pushed
the
vcalvez/github_ci
branch
2 times, most recently
from
49f0149 to
b082c57
Compare
timfel
requested changes
Dec 10, 2025
graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_atexit.txt
Show resolved
Hide resolved
Signed-off-by: Ariouz <virgil.calvez@gmail.com>
This fixes: python-unittest-standalone by downloading and exporting GRADLE_JAVA_HOME NOTE: This only works on linux at this time, other platforms will follow WIP: Download Links depending on platform Todo: Build link using self.runs_on
Default PATH seems to not be evaluated even in defined in jsonnet file, manually set
Ariouz
force-pushed
the
vcalvez/github_ci
branch
from
b082c57 to
22ee071
Compare
Member
Author
Ariouz
force-pushed
the
vcalvez/github_ci
branch
from
a7b09ad to
d591ea3
Compare
msimacek
reviewed
Dec 15, 2025
Ariouz
changed the title
* Fix windows python install (#17) * Skip Python from system_packages to avoid duplicate install - errors on windows runner * mx is cloned, err in system packages * Rm debug message * Skip mx/python in install system packages step * Set retagger base branch to the workflow base one * Add logs/artifacts rentention days inputs * Fix and optimize retagger * Fix retagger git diff on wrong branch * -github unittest tag * Ignore logs upload warning * Don't save artifacts produced in retagger jobs * Move test_patched_pip to tagged tests * Disable test_wheel on github_ci * Retagger set continue-on-error to true * Set git clone timeout
msimacek
approved these changes
Dec 18, 2025
timfel
approved these changes
Dec 23, 2025
Member
|
please remove the |
steve-s
reviewed
Dec 29, 2025
| if self.runs_on == "windows-latest": | ||
| return (f""" | ||
| Invoke-WebRequest -Uri {download_link} -OutFile {filename} | ||
| $dirname = (& tar -tzf {filename} | Select-Object -First 1).Split('/')[0] |
Member
There was a problem hiding this comment.
this looks suspicious? It uses tar, but get_download_link downloads zip for windows. Also should it concatenate the commands with some Windows shell version of &&?
steve-s
reviewed
Dec 29, 2025
| with open(path) as f: | ||
| data = json.load(f) | ||
| for result in data: | ||
| name, status, duration = result.values() |
Member
There was a problem hiding this comment.
can it use explicit dictionary keys?
steve-s
reviewed
Dec 29, 2025
| } | ||
| - name: Actions/Checkout | ||
| uses: actions/checkout@main |
Member
There was a problem hiding this comment.
is checkout@main intentional, elsewhere it's checkout@v4. Pinned version is probably better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it adds a few things, detailed descriptions are located in fork's PRs.
Python unittest retagger jobs + PR checks: Ariouz#1 (Ariouz@68cff18)
Weekly retagger workflow, github exclusion tag: Ariouz#3
Auto PR on weekly retagger: Ariouz#8 merged in 3
Windows build: Ariouz#5 merged in 3
Platforms: Linux and Windows, github hosted runner for macos has too low mem to build.
This also applies all retags for linux amd64, linux aarch64, windows retagger is still running
Tests ran on PR: https://github.com/Ariouz/graalpython/actions/runs/20066056924
Weekly retagger WF: https://github.com/Ariouz/graalpython/actions/runs/20058297116: Ariouz#13