[GR-78917] Use reference queue signal thread. - #1124
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a watcher thread for the reference queue and signals the main thread that references are available for draining.
Previously, the main thread tried to poll the reference queue way too often. When running workloads with a lot of C API transitions, the main thread would try to poll the refq even more often that the GC would run. Further, polling means that a lock needs to be acquired which can rather be costly.
The approach in this PR is to have a separate thread that watches the refq and as soon as one is available, it would signal that to the main thread which then does the full draining.
The goal is that the main thread just needs to do one (volatile) read for that on the fast path.
If async actions are disabled, we still need to do the full draining on the main thread.