Skip to content

docs: fix stale references to retired entrypoint-attribution functions - #2552

Merged
carlos-alm merged 1 commit into
mainfrom
fix/issue-2437
Aug 17, 2026
Merged

docs: fix stale references to retired entrypoint-attribution functions#2552
carlos-alm merged 1 commit into
mainfrom
fix/issue-2437

Conversation

@carlos-alm

Copy link
Copy Markdown
Contributor

Summary

Closes #2437.

#2434 retired markEntrypointTargets/mark_entrypoint_targets and
clearEntrypointAttributionForRemovedFiles/clear_entrypoint_attribution_for_removed_files
in favor of persistEntrypointCalls + projectEntrypointAttribution
(apply_entrypoint_attribution on the Rust side), but left two comments
pointing readers at the removed names. Verified via grep -rn across
src/, crates/codegraph-core/src/, tests/ that no other references
remain besides the one in issue-2428-watch-python-entrypoints.test.ts's
header, which the issue itself correctly identifies as intentional
historical context (describing the bug #2428 fixed, at the time it used
those names) and should stay as-is — left untouched.

Fix

  • crates/codegraph-core/src/graph/classifiers/roles.rs:454 — swapped the
    retired name for the current one (apply_entrypoint_attribution).
  • tests/integration/issue-2392-python-entrypoints.test.ts:245-250
    needed more than a name swap: the comment described a dedicated
    "pre-purge capture" step for deleted guard files that the current
    evidence+projection design doesn't have. Deletion is now handled by the
    same generic per-file purge every other per-file table uses
    (preparePurgeStmts's entrypointCalls statement), with
    projectEntrypointAttribution re-deriving the flag afterward. Rewrote
    the comment to describe the actual current mechanism.

Test plan

  • grep -rn sweep across src/, crates/codegraph-core/src/,
    tests/ confirms zero remaining references to the retired names
    outside the one intentionally-preserved historical comment.
  • cargo build --lib, cargo fmt --check clean.
  • npx tsc --noEmit, npm run lint clean.
  • tests/integration/issue-2392-python-entrypoints.test.ts (22 tests,
    both engines) still passes — comment-only change, no behavior touched.

#2437)

#2434 retired markEntrypointTargets/mark_entrypoint_targets and
clearEntrypointAttributionForRemovedFiles/clear_entrypoint_attribution_for_removed_files
in favor of persistEntrypointCalls + projectEntrypointAttribution
(apply_entrypoint_attribution on the Rust side), but left two comments
pointing readers at the removed names — verified via grep across src/,
crates/, tests/ that no other references remain besides the one in
issue-2428-watch-python-entrypoints.test.ts's header, which intentionally
describes the historical bug being fixed and should stay as-is.

roles.rs's comment just needed the name swapped. The issue-2392 test's
comment needed more than that: it described a dedicated "pre-purge
capture" step for deleted guard files that the current evidence+projection
design doesn't have — deletion is now handled by the same generic
per-file purge every other per-file table uses, with projection re-deriving
the flag afterward. Rewrote it to describe the actual current mechanism
rather than mechanically substituting names for a step that no longer
exists.

docs check acknowledged: comment-only fix inside source files, no README/
CLAUDE.md/ROADMAP.md surface affected.
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates stale comments to use the current entrypoint-attribution terminology and accurately describe deleted-file evidence cleanup.

  • Replaces the retired Rust attribution function name with apply_entrypoint_attribution.
  • Documents the generic entrypoint_calls purge and subsequent attribution projection used during incremental deletion.

Confidence Score: 5/5

The PR appears safe to merge because it only corrects comments, and the revised descriptions match the current implementation.

The updated function reference and deleted-file cleanup explanation are consistent with the Rust and TypeScript entrypoint attribution flows, with no executable behavior changed.

Important Files Changed

Filename Overview
crates/codegraph-core/src/graph/classifiers/roles.rs Correctly updates a stale comment to name the Rust function that projects entrypoint evidence before role classification.
tests/integration/issue-2392-python-entrypoints.test.ts Correctly revises the regression-test explanation to match the current generic purge and projection flow.

Reviews (1): Last reviewed commit: "docs: fix stale references to retired en..." | Re-trigger Greptile

@carlos-alm
carlos-alm merged commit b6fed8f into main Aug 17, 2026
50 of 52 checks passed
@carlos-alm
carlos-alm deleted the fix/issue-2437 branch August 17, 2026 05:47
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale doc references to retired mark_entrypoint_targets / clearEntrypointAttributionForRemovedFiles

1 participant