docs: fix stale references to retired entrypoint-attribution functions - #2552
Merged
Conversation
#2437) #2434 retired markEntrypointTargets/mark_entrypoint_targets and clearEntrypointAttributionForRemovedFiles/clear_entrypoint_attribution_for_removed_files in favor of persistEntrypointCalls + projectEntrypointAttribution (apply_entrypoint_attribution on the Rust side), but left two comments pointing readers at the removed names — verified via grep across src/, crates/, tests/ that no other references remain besides the one in issue-2428-watch-python-entrypoints.test.ts's header, which intentionally describes the historical bug being fixed and should stay as-is. roles.rs's comment just needed the name swapped. The issue-2392 test's comment needed more than that: it described a dedicated "pre-purge capture" step for deleted guard files that the current evidence+projection design doesn't have — deletion is now handled by the same generic per-file purge every other per-file table uses, with projection re-deriving the flag afterward. Rewrote it to describe the actual current mechanism rather than mechanically substituting names for a step that no longer exists. docs check acknowledged: comment-only fix inside source files, no README/ CLAUDE.md/ROADMAP.md surface affected.
Contributor
Greptile SummaryUpdates stale comments to use the current entrypoint-attribution terminology and accurately describe deleted-file evidence cleanup.
Confidence Score: 5/5The PR appears safe to merge because it only corrects comments, and the revised descriptions match the current implementation. The updated function reference and deleted-file cleanup explanation are consistent with the Rust and TypeScript entrypoint attribution flows, with no executable behavior changed. Important Files Changed
Reviews (1): Last reviewed commit: "docs: fix stale references to retired en..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2437.
#2434 retired
markEntrypointTargets/mark_entrypoint_targetsandclearEntrypointAttributionForRemovedFiles/clear_entrypoint_attribution_for_removed_filesin favor of
persistEntrypointCalls+projectEntrypointAttribution(
apply_entrypoint_attributionon the Rust side), but left two commentspointing readers at the removed names. Verified via
grep -rnacrosssrc/,crates/codegraph-core/src/,tests/that no other referencesremain besides the one in
issue-2428-watch-python-entrypoints.test.ts'sheader, which the issue itself correctly identifies as intentional
historical context (describing the bug #2428 fixed, at the time it used
those names) and should stay as-is — left untouched.
Fix
crates/codegraph-core/src/graph/classifiers/roles.rs:454— swapped theretired name for the current one (
apply_entrypoint_attribution).tests/integration/issue-2392-python-entrypoints.test.ts:245-250—needed more than a name swap: the comment described a dedicated
"pre-purge capture" step for deleted guard files that the current
evidence+projection design doesn't have. Deletion is now handled by the
same generic per-file purge every other per-file table uses
(
preparePurgeStmts'sentrypointCallsstatement), withprojectEntrypointAttributionre-deriving the flag afterward. Rewrotethe comment to describe the actual current mechanism.
Test plan
grep -rnsweep acrosssrc/,crates/codegraph-core/src/,tests/confirms zero remaining references to the retired namesoutside the one intentionally-preserved historical comment.
cargo build --lib,cargo fmt --checkclean.npx tsc --noEmit,npm run lintclean.tests/integration/issue-2392-python-entrypoints.test.ts(22 tests,both engines) still passes — comment-only change, no behavior touched.