docs: add conflict resolution guidance to /review skill#476
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Greptile SummaryThis PR replaces the terse one-liner "Resolve all conflicts by reading the conflicting files…" in the The added guidance is a clear improvement: it covers PR description context, commit history for both sides, reviewer comments, and a merge-base diff check. The previous review thread's concern (only one side of the conflict was inspected) has been addressed by adding the Key issues found:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Conflict detected] --> B[git merge origin/base-branch]
B --> C{Conflicts?}
C -- No --> Z[Stage & commit & push]
C -- Yes --> D[Read PR description\ngh pr view]
D --> E[git log PR side\norigin/base..HEAD -- file]
E --> F[git log base side\nHEAD..origin/base -- file\n⚠ duplicated in bullets 3 & 4]
F --> G[Read reviewer comments\ngh api pulls/comments + issues/comments]
G --> H[git diff merge-base\nIntentional vs stale?]
H --> I{Decision}
I -- PR changed deliberately\nbase is stale --> J[Keep PR version]
I -- base introduced fix\nPR lacks it --> K[Keep base version]
I -- Both sides changed\nintentionally --> L[Manually merge both]
J --> Z
K --> Z
L --> Z
Last reviewed commit: ff33639 |
When resolving merge conflicts, the review skill must check PR commit history and reviewer comments before choosing which side to keep — never assume based on syntax alone.
Expand the /review skill's conflict guidance to require reading the PR description, linked issues, and main-side commit history — not just the PR's own commits and reviewer comments. If you don't know why a line exists, you cannot resolve the conflict correctly.
ff33639 to
1d9e968
Compare
Summary
/reviewskill's conflict resolution step (2b) to check PR commit history and reviewer comments before choosing which side of a conflict to keepContext
During conflict resolution on #475, the template-literal syntax was the PR's intentional change but was nearly discarded in favor of main's stale concatenation. The review skill lacked guidance to check why each side differs before resolving.
Test plan
/reviewon a PR with conflicts and verify it checks commit history before resolving