[#461] 빌드, 테스트 타깃에 SwiftLint를 구성한다#462
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 pull request는 SwiftLint를 빌드 도구 플러그인으로 통합하고 모듈별 린트 설정을 표준화했습니다. 또한 WidgetSnapshotUpdater의 인터페이스를 단순화하여 내부에서 설정을 직접 참조하도록 수정하였으며, 테스트 코드에 Fixture 패턴을 도입하여 구조를 개선했습니다. 리뷰 과정에서 WidgetSnapshotUpdaterSpy의 접근 제한자를 private으로 유지하여 캡슐화를 강화하라는 의견이 제시되었습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
.swiftlint.yml추가 및 루트 SwiftLint 설정 참조 구조 구성🔍 상세
DevLogApp,DevLogCore,DevLogData,DevLogDomain,DevLogInfra,DevLogPersistence,DevLogPresentation,DevLogWidgetCore에 SwiftLint 플러그인 연결.swiftlint.yml을parent_config로 참조하도록 구성.swiftlint-tests.yml을parent_config로 참조하도록 구성identifier_name비활성화WidgetSnapshotUpdater의 히트맵 스냅샷 갱신 API에서 테스트 전용 성격의selectedActivityKinds오버로드 제거Fixture타입으로 분리해large_tuple위반 해결AppleAuthResponse생성자 제거📸 영상 / 이미지 (Optional)