🌱 Add a Makefile target and start running the API diff linter as part of CI #2411

camilamacedo86 · 2025-12-24T12:01:06Z

Description

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

openshift-ci · 2025-12-24T12:01:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2025-12-24T12:01:15Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`2c6d769`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69603f37ec3bcf0008594725
😎 Deploy Preview	https://deploy-preview-2411--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2025-12-24T12:25:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (b871e7e) to head (2c6d769).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
+ Coverage   69.61%   73.05%   +3.44%     
==========================================
  Files         100      100              
  Lines        7641     7641              
==========================================
+ Hits         5319     5582     +263     
+ Misses       1888     1623     -265     
- Partials      434      436       +2

Flag	Coverage Δ
e2e	`46.76% <ø> (-0.12%)`	⬇️
experimental-e2e	`48.74% <ø> (+35.06%)`	⬆️
unit	`57.11% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hack/api-lint-diff/run.sh

pedjak

how hard would, i.e. what is the effort to fix all api linter issues in single PR instead of introducing this logic to compare with the baseline?

camilamacedo86 · 2026-01-02T14:56:54Z

how hard would, i.e. what is the effort to fix all api linter issues in single PR instead of introducing this logic to compare with the baseline?

Very high — and it may never will be done. For example: It fails #2413. I raised for we discuss and based on the discussion it seems that we never will change.

Given that, there are many cases we might never want to fix, we will end up saying “this is expected” just to get the PR merged. Then it merges, and in the next round we will be expected to pass again anyway.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hack/api-lint-diff/run.sh

.github/workflows/sanity.yaml

…f CI.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/api-diff-lint.yaml

.github/workflows/sanity.yaml

hack/api-lint-diff/run.sh

Co-authored-by: Todd Short <tmshort@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/api-diff-lint.yaml

hack/api-lint-diff/run.sh

grokspawn · 2026-01-08T21:10:28Z

.github/workflows/api-diff-lint.yaml

+  workflow_dispatch:
+  pull_request:
+  merge_group:
+  push:
+    branches:
+    - main


Any reason we want to run this for the other event types?
go-verdiff and crd-diff are only executed for pull_request.

This would also obviate the copilot review comments related to other-than-pull-request workflows.

That is a good idea.
I saw Copilot reviews too now.
Great that solves all.
Done. Thx

.github/workflows/api-diff-lint.yaml

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/api-diff-lint.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 24, 2025 12:01

camilamacedo86 requested a review from a team as a code owner December 24, 2025 12:01

openshift-ci bot requested review from bentito and tmshort December 24, 2025 12:01

Copilot started reviewing on behalf of camilamacedo86 December 24, 2025 12:01 View session

This comment was marked as outdated.

Sign in to view

camilamacedo86 force-pushed the add-ci-api-diff branch from a0b209a to 23d2bf7 Compare December 24, 2025 12:05

camilamacedo86 changed the title ~~🌱 Add ci api diff~~ WIP: 🌱 Add ci api diff Dec 24, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025

camilamacedo86 force-pushed the add-ci-api-diff branch from 23d2bf7 to a510d69 Compare December 24, 2025 12:10

Copilot AI review requested due to automatic review settings December 24, 2025 12:10

camilamacedo86 changed the title ~~WIP: 🌱 Add ci api diff~~ WIP: 🌱 Add a Makefile target and start running the API diff linter as part of CI Dec 24, 2025

Copilot started reviewing on behalf of camilamacedo86 December 24, 2025 12:10 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

camilamacedo86 force-pushed the add-ci-api-diff branch 2 times, most recently from ea41264 to 1569876 Compare December 24, 2025 16:09

Copilot AI review requested due to automatic review settings December 24, 2025 16:09

Copilot started reviewing on behalf of camilamacedo86 December 24, 2025 16:09 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

hack/api-lint-diff/run.sh Show resolved Hide resolved

hack/api-lint-diff/run.sh Show resolved Hide resolved

hack/api-lint-diff/run.sh Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the add-ci-api-diff branch from 1569876 to 4dbd085 Compare December 24, 2025 16:17

camilamacedo86 changed the title ~~WIP: 🌱 Add a Makefile target and start running the API diff linter as part of CI~~ (https://github.com/operator-framework/operator-controller/pull/2410) 🌱 Add a Makefile target and start running the API diff linter as part of CI Dec 24, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025

pedjak reviewed Jan 2, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 5, 2026 23:54

camilamacedo86 force-pushed the add-ci-api-diff branch from 4dbd085 to 2b86735 Compare January 5, 2026 23:54

camilamacedo86 changed the title ~~(Blocked operator-controller/pull/2410) 🌱 Add a Makefile target and start running the API diff linter as part of CI~~ 🌱 Add a Makefile target and start running the API diff linter as part of CI Jan 5, 2026

Copilot started reviewing on behalf of camilamacedo86 January 5, 2026 23:54 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

hack/api-lint-diff/run.sh Show resolved Hide resolved

.github/workflows/sanity.yaml Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the add-ci-api-diff branch from 2b86735 to 2d13af9 Compare January 8, 2026 06:53

Copilot AI review requested due to automatic review settings January 8, 2026 07:01

camilamacedo86 force-pushed the add-ci-api-diff branch from 2d13af9 to 44e8651 Compare January 8, 2026 07:01

Copilot started reviewing on behalf of camilamacedo86 January 8, 2026 07:02 View session

Add a Makefile target and start running the API diff linter as part o…

cf3eedf

…f CI.

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.github/workflows/api-diff-lint.yaml Show resolved Hide resolved

.github/workflows/sanity.yaml Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the add-ci-api-diff branch from 44e8651 to cf3eedf Compare January 8, 2026 07:19

tmshort reviewed Jan 8, 2026

View reviewed changes

hack/api-lint-diff/run.sh Outdated Show resolved Hide resolved

Update hack/api-lint-diff/run.sh

336ef3b

Co-authored-by: Todd Short <tmshort@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 8, 2026 19:38

Copilot started reviewing on behalf of camilamacedo86 January 8, 2026 19:39 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.github/workflows/api-diff-lint.yaml Show resolved Hide resolved

hack/api-lint-diff/run.sh Outdated Show resolved Hide resolved

grokspawn reviewed Jan 8, 2026

View reviewed changes

camilamacedo86 commented Jan 8, 2026

View reviewed changes

.github/workflows/api-diff-lint.yaml Outdated Show resolved Hide resolved

Run for pull requests only

965cee9

Copilot AI review requested due to automatic review settings January 8, 2026 23:17

Copilot started reviewing on behalf of camilamacedo86 January 8, 2026 23:17 View session

camilamacedo86 requested review from grokspawn, pedjak and tmshort January 8, 2026 23:19

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.github/workflows/api-diff-lint.yaml Outdated Show resolved Hide resolved

.github/workflows/api-diff-lint.yaml Outdated Show resolved Hide resolved

Update .github/workflows/api-diff-lint.yaml

9221fe2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 8, 2026 23:34

Update .github/workflows/api-diff-lint.yaml

9b3ef7b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of camilamacedo86 January 8, 2026 23:34 View session

Update hack/api-lint-diff/run.sh

2c6d769

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jan 8, 2026

View reviewed changes

🌱 Add a Makefile target and start running the API diff linter as part of CI #2411

Are you sure you want to change the base?

🌱 Add a Makefile target and start running the API diff linter as part of CI #2411

Conversation

camilamacedo86 commented Dec 24, 2025

Description

Reviewer Checklist

Uh oh!

openshift-ci bot commented Dec 24, 2025

Uh oh!

netlify bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedjak left a comment

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 commented Jan 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

grokspawn Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

netlify bot commented Dec 24, 2025 •

edited

Loading

codecov bot commented Dec 24, 2025 •

edited

Loading

grokspawn Jan 8, 2026 •

edited

Loading

camilamacedo86 Jan 8, 2026 •

edited

Loading