fix: handling delete non-active dependent when parent reconcile condition false#3273
Open
csviri wants to merge 7 commits intooperator-framework:mainfrom
Open
fix: handling delete non-active dependent when parent reconcile condition false#3273csviri wants to merge 7 commits intooperator-framework:mainfrom
csviri wants to merge 7 commits intooperator-framework:mainfrom
Conversation
…tion false Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of deleting non-active dependents when parent reconciliation conditions are false, and improves the event source management for activation conditions. The changes introduce a condition result caching mechanism to optimize condition evaluation and refactor the deletion logic for better clarity.
Changes:
- Added condition result caching to avoid redundant evaluations within a single reconciliation cycle
- Refactored deletion handling to check activation conditions at execution time rather than during marking phase
- Enhanced InformerEventSource with a guard clause to prevent starting an already-running event source
- Added test coverage for event source registration/deregistration behavior with activation conditions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WorkflowReconcileExecutorTest.java | Added EventSourceRetriever mock and three new test cases for activation condition event source management |
| InformerEventSource.java | Added guard clause in start() method to prevent redundant starts |
| WorkflowReconcileExecutor.java | Refactored deletion logic and removed activation condition parameter from handleReconcileOrActivationConditionNotMet |
| AbstractWorkflowExecutor.java | Added condition result caching in isConditionMet() method |
| BaseWorkflowResult.java | Added getConditionResult() method to support condition caching |
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com