[drgrice1]

Several places built a user's full name by joining the first and last names manually instead of using the full_name method of the user database record. Those places now all use that method.

[somiaj]

Thinking out loud. Since the database returns '' for null rows, would it be worth updating the full_name method to use the join(' ', $record->first_name, $record->last_name) approach? Or just easier to read with its current approach? I guess there isn't really that much difference, outside of making the method a one line. Could also use $record->first_name // '' to deal with undefined case.

[somiaj]

Looks good. This will help Claude out too.

[somiaj]

Nevermind previous comment, join(' ', '', '') would actually be ' ', leaving a space. So trying to simplify this would actually be worse unless some other processing was done to trim any white space.

[drgrice1]

This takes things just a bit further. There are numerous places where the user's name is displayed in the last, first format (and sometimes with (user_id) after it or using the user_id as a fallback). There is now a sortable_name method for the user record that returns the last, first format falling back to only the first or only the last or the empty string.

[somiaj]

In testing the user menu, full_name and the other methods can return a name with only white space if the first and last name in the data base are ' '. This makes it so full_name || user_id logic may fail to show the user_id for a white space name. This is a tiny edge case, but should the methods be updated to trim the white space from first name and last name? My guess is this really isn't a problem, and something that occurs with aggressive testing, so mostly just commenting that it can happen.

[drgrice1]

When users are added via the "Accounts Manager" we trim spaces from the first and last name. I note that we don't do that for users added via LTI. Although I think that is going to be pretty unlikely, and almost always the result of some data entry error. In any case, I updated the full_name and sortable_name methods to treat a first or last name consisting entirely of white space as not set.

[somiaj]

Looks like the Options.pm page doesn't trim white space. I will go update that in my changes with the user menu.