Repository navigation
Conversation
drgrice1
force-pushed
the
safe-better-clean-stash
branch
2 times, most recently
from
October 27, 2026 21:08
702e0b5 to
4ed8ac7
Compare
drgrice1
force-pushed
the
safe-better-clean-stash
branch
4 times, most recently
from
November 4, 2026 11:45
576f4cf to
7809627
Compare
drgrice1
force-pushed
the
safe-better-clean-stash
branch
from
November 9, 2026 17:40
7809627 to
7476c10
Compare
somiaj
approved these changes
Nov 10, 2026
somiaj
left a comment
somiaj
left a comment
Contributor
There was a problem hiding this comment.
Tested with achievements and they seem to still work fine. Didn't test achievement email notifications. Anything in particular we should test to try to break things (I only tested stuff still worked).
Member
Author
|
Test achievement evaluators and that the course environment works. Test achievement notifications if you can test emails. |
drgrice1
force-pushed
the
safe-better-clean-stash
branch
2 times, most recently
from
November 10, 2026 22:32
a62f675 to
72141fe
Compare
This uses the same shared-package defense from the pg pull request openwebwork/pg#1565. The `snapshot_hooks` method can be called to record the hooks in the shared packages once the compartment is fully set up but before the user provided code runs, and `_clean_stash` then uses that to restore any shared hook the user supplied code overwrites in place and strip all hooks the user provided code adds (so a hook in a new `Mojo::Exception::Evil` package is stripped, but `Mojo::Exception`'s overloads are left alone). `snapshot_hooks` is called from the `AchievementNotification` task, which is the only consumer that shares whole package stashes into a compartment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
drgrice1
force-pushed
the
safe-better-clean-stash
branch
from
November 12, 2026 21:50
72141fe to
a51786b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the same shared-package defense from the pg pull request openwebwork/pg#1565.
The
snapshot_hooksmethod can be called to record the hooks in the shared packages once the compartment is fully set up but before the user provided code runs, and_clean_stashthen uses that to restore any shared hook the user supplied code overwrites in place and strip all hooks the user provided code adds (so a hook in a newMojo::Exception::Evilpackage is stripped, butMojo::Exception's overloads are left alone).snapshot_hooksis called from theAchievementNotificationtask, which is the only consumer that shares whole package stashes into a compartment.