Skip to content

make a few anchors with 'role="button"' respond to space #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex-Jordan wants to merge 1 commit into
base: WeBWorK-2.21
Choose a base branch
from
+26 −1
Open

make a few anchors with 'role="button"' respond to space #3096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions htdocs/js/CourseAdmin/manage_lti_course_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
(() => {
// Make the LTI configuration info buttons activate upon use of the spacebar.
for (const btn of document.querySelectorAll('.lti-config-btn')) {
btn.addEventListener('keydown', (e) => {
if (e.key === ' ') {
e.preventDefault();
btn.click();
}
});
}
})();
10 changes: 10 additions & 0 deletions htdocs/js/JobManager/jobmanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@
filter_select.addEventListener('change', toggle_filter_elements);
toggle_filter_elements();
}

// Make the job result buttons activate when using the spacebar.
for (const btn of document.querySelectorAll('.result-btn')) {
btn.addEventListener('keydown', (e) => {
if (e.key === ' ') {
e.preventDefault();
btn.click();
}
});
}
})();
6 changes: 5 additions & 1 deletion templates/ContentGenerator/CourseAdmin/manage_lti_course_map_form.html.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
% content_for js => begin
<%= javascript getAssetURL($ce, 'js/CourseAdmin/manage_lti_course_map.js'), defer => undef =%>
% end
Comment thread
drgrice1 marked this conversation as resolved.
%
<h2><%= maketext('Manage LTI Course Map') %> <%= $c->helpMacro('AdminManageLTICourseMap') %></h2>
<%= form_for current_route, method => 'POST', begin =%>
<%= $c->hidden_authen_fields =%>
Expand Down Expand Up @@ -30,7 +34,7 @@
</td>
<td class="text-center">
% if ($ltiConfigs->{$_}{LTIVersion} && $ltiConfigs->{$_}{LTIVersion} =~ /^v1p[13]$/) {
<a href="#" role="button" data-bs-toggle="modal"
<a href="#" role="button" class="lti-config-btn" data-bs-toggle="modal"
data-bs-target="#<%= $_ %>-config-modal">
<i class="fa-solid fa-circle-question fa-xl"></i>
<span class="visually-hidden"><%= maketext('LTI Configuration') %></span>
Expand Down