Conversation
Member
|
😱 Is this the GitHub equivalent of a trust-fall? 😆 |
Contributor
Author
|
Hmm... so, is there a git way to confirm that the changes here only affect PCC files? Let me look into this on my end. I'm surprised we have that many files, but maybe it's around 2500 and then doubled for the OPL and Contrib. Maybe it will help if I split into to PRs based on that. Or chunk it out by some folders versus other folders. |
Member
|
I just want to confirm that this is indeed limited to PCC files -- 5k is pretty massive. If it isn't too much work, splitting this into PRs at least for OPL/PCC vs Contrib/PCC sounds like a good start. 👍 |
Member
|
@Alex-Jordan Looking at this again. There are conflicts now and it would be helpful if these were broken up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is several years of accumulated changes to PCC files in the OPL. Every change here is either in
OpenProblemLibrary/PCC,OpenProblemLibrary/macros/PCC, orContrib/PCC.