Conversation
this wasn't supposed to be included...
this wasn't supposed to be included...
This wasn't supposed to be included...
drdrew42
approved these changes
Apr 27, 2023
Member
drdrew42
left a comment
drdrew42
left a comment
There was a problem hiding this comment.
Thank you for your contributions! I have made a few comments, mostly FYI stuff, hopefully you find the suggestions useful.
| ## Author(Benjamin Walter) | ||
| ## Level(3) | ||
| ## KEYWORDS('linear algebra','vectors') | ||
| ## MO(1) |
Member
There was a problem hiding this comment.
This problem does not use MathObjects. A Context is chosen, but none of the variables are actually MathObjects (making the context irrelevant).
| ## MO(1) | ||
| ## Static(0) | ||
| ## KEYWORDS('algebra', 'matrix operation', 'matrix', 'determinant') | ||
| # KEYWORDS('algebra', 'matrix operation', 'matrix', 'determinant') |
Member
There was a problem hiding this comment.
This tag line should retain its double-#
|
|
||
| Context("Numeric"); | ||
| #Context()->constants->remove(pi); | ||
| Context()->variables->add(pi=>['Real',TeX=>"\pi"]); |
Member
There was a problem hiding this comment.
I imagine that your aim here is to avoid allowing students to enter decimal approximations for the solutions. You can accomplish the same thing without adding pi as a variable:
Parser::Number::NoDecimals();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring update to
Contrib/METU-NCC
some new problems (in MAT100), some bug-fixes, some wording changes
Does not include bugfix 4751 (made on a separate branch)
The new MAT100 problems are already tagged and ready to incorporate into the main problem library (I wrote these to cover gaps in current library, so I think they are good additions).