Conversation
The help files now use color styles from the `htdocs/js/Knowls/knowl.scss` file instead of the previous inline styles. Note that the `Entering-Logarithms.html` and `Entering-Logarithms10.html` files had some additional dark blue text color styles that were just dropped. Even in light mode it was rather difficult to distinguish between that dark blue text and the black text right next to it. For the tables I just used Bootstraps bordered table styles rather than creating a specialized style that just does the same thing.
Member
Author
|
Here is a problem file that uses all of the help files for testing. |
somiaj
approved these changes
Oct 1, 2026
somiaj
left a comment
somiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
For anyone else testing this, my browser was caching all the .html help files, so when I tested it out I didn't see the changes. I had to force my browser to not use their cache to be able to see the updated help files.
Member
Author
|
I had the caching issue as well when testing this. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help files now use color styles from the
htdocs/js/Knowls/knowl.scssfile instead of the previous inline styles.Note that the
Entering-Logarithms.htmlandEntering-Logarithms10.htmlfiles had some additional dark blue text color styles that were just dropped. Even in light mode it was rather difficult to distinguish between that dark blue text and the black text right next to it.For the tables I just used Bootstraps bordered table styles rather than creating a specialized style that just does the same thing.