Unit test cleanup - #1553
Open
drgrice1 wants to merge 2 commits into
Open
Unit test cleanup#1553drgrice1 wants to merge 2 commits into
drgrice1 wants to merge 2 commits into
Conversation
drgrice1
force-pushed
the
unit-test-cleanup
branch
3 times, most recently
from
September 27, 2026 15:53
4caca52 to
4f66e8a
Compare
pstaabp
approved these changes
Sep 28, 2026
Remove some `use Data::Dumper` calls that keep showing up for some reason. Remove some other dependencies that aren't needed. In some cases macros are loaded that aren't needed, and in others packages are `use`d that aren't needed. Restructure the `t` directories and file names to be more logical.
Tests that replace the `tikz_text?.pg` problems were added in the
`t/macros_graph/PGtikz.t` file.
Tests that replace the `latex_image_test?.pg` problems are in the new
`t/macros_graph/PGlateximage.t` file.
Tests that replace the `niceTables.pg` file are added in the
`t/macros_ui/niceTables.t` file.
There was a bug in the `lib/LaTeXImage.pm` file that was fixed. If
`$image->texPackages([['xcolor', 'dvipsnames']]) is called (or generally
the array option version with the package `xcolor` called), then
`\usepackage[dvipsnames]{xcolor}` is added twice to the TeX. This is
because the array reference is `ne 'xcolor'`.
There was also a bug in the `niceTables.pl` macro that was fixed. The
`css` method in the macro did not append the css properties to the
`$return` string, and so it only actually added the last css property
considered. Which css property considered was random also, because the
`keys` order would be different every time.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
drgrice1
force-pushed
the
unit-test-cleanup
branch
from
September 28, 2026 11:42
4f66e8a to
495669e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some
use Data::Dumpercalls that keep showing up for some reason.Remove some other dependencies that aren't needed. In some cases macros are loaded that aren't needed, and in others packages are
used that aren't needed.Restructure the
tdirectories and file names to be more logical.The
.pgproblem files that were not actual tests were converted into tests.tikz_text?.pgproblems were added in thet/macros_graph/PGtikz.tfile.latex_image_test?.pgproblems are in the newt/macros_graph/PGlateximage.tfile.niceTables.pgfile are added in thet/macros_ui/niceTables.tfile.There was a bug in the
lib/LaTeXImage.pmfile that was fixed. If$image->texPackages([['xcolor', 'dvipsnames']]) is called (or generally the array option version with the packagexcolorcalled), then\usepackage[dvipsnames]{xcolor}is added twice to the TeX. This is because the array reference isne 'xcolor'`.There was also a bug in the
niceTables.plmacro that was fixed. Thecssmethod in the macro did not append the css properties to the$returnstring, and so it only actually added the last css property considered. Which css property considered was random also, because thekeysorder would be different every time.