Deprecate some more macros and set a warning if using.#1256
Merged
Alex-Jordan merged 5 commits intoopenwebwork:PG-2.20from Jun 24, 2025
Merged
Deprecate some more macros and set a warning if using.#1256Alex-Jordan merged 5 commits intoopenwebwork:PG-2.20from
Alex-Jordan merged 5 commits intoopenwebwork:PG-2.20from
Conversation
pstaabp
force-pushed
the
loadmacros-deprecate
branch
from
083fac3 to
21e9566
Compare
Include the rest of the Union macros in the deprecate and move the PGnumericevaluators out of deprecate because every problem loads it. In addition show a warning to instructors if a problem is using a deprecated macro.
pstaabp
force-pushed
the
loadmacros-deprecate
branch
from
21e9566 to
f0a28af
Compare
pstaabp
force-pushed
the
loadmacros-deprecate
branch
from
9240772 to
71cbbb8
Compare
Save the list of deprecated macros in the PGloadfiles object.
Member
Author
|
Updated using @somiaj code to handle the warnings by adding to the PG object and then handle on the WeBWorK side. Note: this needs openwebwork/webwork2#2752 to work. |
Member
Author
|
Remove the detection of deprecated macros on the PG side and now uses a different mechanism on the WeBWorK side. |
drgrice1
approved these changes
Jun 24, 2025
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
Lets get this in so that the macros that shouldn't have been deprecated are back where they belong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the rest of the Union macros in the deprecate and move the PGnumericevaluators out of deprecate because every problem loads it.
In addition show a warning to instructors if a problem is using a deprecated macro.
Note: this will affect a lot of macros in the OPL. Seems like the deprecated macro with most references in the OPL is the
answerFormatHelpmacro.I will plan to put a PR to remove that macro from all of the OPL problems that call it.