whitelists updates - #4517
Merged
Merged
whitelists updates#4517
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates the Windows SDL library whitelist for current OpenVINO dependencies.
Changes:
- Removes obsolete
ClientApi.dll. - Adds
openvino_gguf_frontend.dll.
File summaries
| File | Description |
|---|---|
tests/sdl/whitelists.py |
Updates Windows library whitelist entries. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pgladkows
marked this pull request as draft
September 17, 2026 12:23
mzegla
approved these changes
Sep 17, 2026
pgladkows
marked this pull request as ready for review
September 18, 2026 08:51
pgladkows
requested review from
mzegla and
porlows1
and
a lite review from Copilot
September 18, 2026 08:51
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Python-only Windows DLLs are currently included in the default Windows whitelist.
Review details
Suppressed comments (1)
tests/sdl/whitelists.py:156
- These DLLs are copied only when
with_python=trueinwindows_create_package.bat:69-99, but placing them inOvmsBaseType.WINDOWSmakes them part of the default whitelist. Move them toOvmsBaseType.WINDOWS_PYTHON; otherwise a no-Python Windows package can incorrectly pass SDL with these Python-only files, while the Python-specific whitelist does not represent the files that were added.
'libovmspython.dll',
'libpython_calculators.dll',
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
mzegla
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.devtools.intel.com/browse/CVS-193500
https://jira.devtools.intel.com/browse/CVS-193149
https://jira.devtools.intel.com/browse/CVS-193500
http://validationreports.sclab.intel.com:8001/reports/test_result/6aabd6d016f5345203b2bb53
http://validationreports.sclab.intel.com:8001/reports/test_result/6aac0e7b9c637090ff6941a9
ubuntu24: http://validationreports.sclab.intel.com:8001/reports/build_number_report?test_session_build_number=ci-ai-test-17793&environment=clx9_mclx-62
redhat: http://validationreports.sclab.intel.com:8001/reports/build_number_report?test_session_build_number=ci-ai-test-17794&environment=clx7_mclx-60
windows: http://validationreports.sclab.intel.com:8001/reports/build_number_report?test_session_build_number=libs-updates-070926_2067&environment=ovms_win_ptl-windows_test-2067
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``