Skip to content

CVS-182105_include_raw_uat_test_name#4025

Open
ngrozae wants to merge 1 commit intomainfrom
CVS-182105_include_raw_uat_test_name
Open

CVS-182105_include_raw_uat_test_name#4025
ngrozae wants to merge 1 commit intomainfrom
CVS-182105_include_raw_uat_test_name

Conversation

@ngrozae
Copy link
Collaborator

@ngrozae ngrozae commented Feb 27, 2026

🛠 Summary

CVS-182105 updates for testing framework

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings February 27, 2026 17:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the functional testing utilities to interpret "true"/"false" tokens inside comma-separated environment-variable lists as Python booleans, aligning list parsing more closely with existing boolean env var handling.

Changes:

  • Enhance get_list() to coerce list items equal to "true"/"false" (case-insensitive) into True/False.

Comment on lines +92 to +94
if item.lower() == "true":
value[index] = True
elif item.lower() == "false":
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_list() now converts list items equal to "true"/"false" to booleans, but it does not trim whitespace. Common env var values like "true, false" will produce " false" which won’t match and will remain a string, leading to inconsistent types and surprising behavior. Consider stripping each item before lowercasing (and ideally centralizing the conversion logic so it matches get_bool() behavior).

Suggested change
if item.lower() == "true":
value[index] = True
elif item.lower() == "false":
normalized = item.strip().lower()
if normalized == "true":
value[index] = True
elif normalized == "false":

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants