Add spring autoconfiguration for metrics and prometheus reporter#16
Add spring autoconfiguration for metrics and prometheus reporter#16objectiser merged 3 commits intoopentracing-contrib:masterfrom
Conversation
objectiser
changed the title
jpkrohling
left a comment
jpkrohling
left a comment
There was a problem hiding this comment.
Apart from two spacing issues, LGTM (as usual, I can't judge the Spring semantics)
| <artifactId>opentracing-metrics-prometheus</artifactId> | ||
| <version>${project.version}</version> | ||
| <exclusions> | ||
| <exclusion> |
There was a problem hiding this comment.
Why do you exclude it? And why are other promo deps provided? I think this should pull-in all what is needed.
| <version>${project.version}</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>io.prometheus</groupId> |
pavolloffay
left a comment
pavolloffay
left a comment
There was a problem hiding this comment.
dependencies look weird but maybe I am missing something.
| <artifactId>opentracing-metrics-prometheus</artifactId> | ||
| <version>${project.version}</version> | ||
| <exclusions> | ||
| <exclusion> |
There was a problem hiding this comment.
Why do you exclude it? And why are other promo deps provided? I think this should pull-in all what is needed.
|
|
||
| <dependency> | ||
| <groupId>io.opentracing.contrib</groupId> | ||
| <artifactId>opentracing-metrics-prometheus</artifactId> |
There was a problem hiding this comment.
What is the purpose of this artifact? There is one for prometheus so why this has some provided prometheus deps?
There was a problem hiding this comment.
Have removed the exclusions - it was left over from when in the java-spring-cloud repo, so the autoconfigs would become active if prometheus was in the classpath.
|
@jpkrohling @pavolloffay Thanks! |
3 participants
This PR contains code moved from this PR: opentracing-contrib/java-spring-cloud#15
An example of how it simplifies an example can be seen in this PR: objectiser/opentracing-prometheus-example#13