fix(ci): remove workflow-level env block exposing secrets#98
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
WalkthroughThe workflow file removes intermediate environment variables for Huawei Cloud credentials and updates the deployment step to read GitHub secrets directly, reducing indirection and configuration overhead in the GitHub Actions pipeline. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Summary
deploy-obs.yml中顶层env:块对HUAWEI_CLOUD_*secrets 的环境变量映射${{ env.HUAWEI_CLOUD_* }}引用替换为${{ secrets.HUAWEI_CLOUD_* }}直接引用安全问题: 顶层
env:会将 secrets 暴露为整个 workflow 的环境变量,任何 step 都可通过printenv读取。改为直接引用${{ secrets.* }}后,secrets 仅在使用处临时展开。参照: opentiny/tiny-engine#1799
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit