Hotfix/propagate hotkey swap conviction

[gztensor]

Description

Propagates the hotkey-swap conviction lock hotfix from #2731 onto devnet-ready after the reverse lock index work landed.

The migration in pallets/subtensor/src/migrations/migrate_fix_subnet_hotkey_lock_swaps.rs now uses LockingColdkeys when repairing subnet-scoped hotkey swap lock state. It removes old reverse-index entries when taking source locks and inserts the new reverse-index entry when a lock is moved to the destination hotkey, keeping Lock and LockingColdkeys consistent after the migration.

The migration test in pallets/subtensor/src/tests/migration.rs was extended to seed and assert LockingColdkeys state for moved locks, discarded conflict locks, and chained hotkey-swap fixes. The runtime spec_version is bumped from 417 to 418 for the runtime migration.

Behavioral impact: affected stale subnet hotkey-swap lock records are repaired without falling back to a full Lock scan, and the reverse index remains usable for subsequent lock operations. Existing destination lock conflicts continue to preserve the destination lock and discard the old source lock as before.

Testing: targeted migration coverage was updated to validate the new reverse-index behavior.

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: author has write permission, substantial subtensor history, no trusted Gittensor allowlist match; branch hotfix/propagate-hotkey-swap-conviction -> devnet-ready.

The PR does not modify .github/ai-review/*, .github/copilot-instructions.md, dependencies, lockfiles, or build scripts. The runtime migration runs after migrate_populate_locking_coldkeys, uses the populated LockingColdkeys reverse index, removes stale source entries, inserts destination entries for moved locks, and uses saturating weight accounting for the added storage operations.

Findings

No findings.

Prior-comment reconciliation

• a8760b5d: addressed — The current migration charges for the LockingColdkeys prefix walk, source index removals, Lock::take reads/writes, and destination index insertions before moving or discarding locks.

Conclusion

No malicious pattern or security vulnerability was found in the current diff. The prior migration weight-accounting concern remains addressed.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN by trusted allowlists; author has write permission and substantial prior subtensor history, so calibrated as an established contributor.

Description discrepancies

• The PR body says spec_version is bumped from 417 to 418, but the current diff bumps runtime/src/lib.rs from 424 to 426. Update that sentence before merge.

The migration now runs after migrate_populate_locking_coldkeys, so relying on LockingColdkeys for the broad repair path is consistent with runtime-upgrade ordering. The moved, discarded-conflict, and chained hotkey-swap cases update both Lock and LockingColdkeys, and the added test assertions cover reverse-index cleanup and insertion.

git diff --check passed. I did not apply auto-fixes or run cargo; static review was sufficient for this diff. The overlapping PRs appear to share broad runtime/test files rather than duplicate this targeted hotfix.

Findings

No findings.

Conclusion

The lock repair migration preserves the forward and reverse lock indexes across the affected hotkey-swap repair paths, with focused regression coverage. No blocking domain issues found.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍