feat: Add neutron function tools - subnet, port, floating ip#46
Merged
platanus-kr merged 15 commits intodevelopfrom Aug 23, 2025
Merged
Conversation
Collaborator
|
현재 develop 브랜치 기준으로 rebase 후 force push 부탁드립니다 |
halucinor
reviewed
Aug 16, 2025
platanus-kr
force-pushed
the
feat/tool-neutron-function-subnet-port-floating-ip
branch
from
15d772d to
518ef4b
Compare
platanus-kr
changed the title
halucinor
requested changes
Aug 18, 2025
Collaborator
|
docstring 변경 필요사항
|
platanus-kr
force-pushed
the
feat/tool-neutron-function-subnet-port-floating-ip
branch
from
e49a9a9 to
cd91c73
Compare
Collaborator
Author
|
Floating IP는 아래와 같이 통합했습니다.
|
- remove custom raise - remove test case relation removing raise
platanus-kr
force-pushed
the
feat/tool-neutron-function-subnet-port-floating-ip
branch
from
98cbac5 to
5e5c951
Compare
halucinor
reviewed
Aug 23, 2025
Collaborator
halucinor
left a comment
halucinor
left a comment
There was a problem hiding this comment.
UNSET 변수에 대한 의견,
UNSET 변수는 업데이트 함수 내에서 값을 제거 하는 값으로 사용이 되는걸로 보입니다. 다만 이러한 방식의 변수 사용은 인자 해석을 난해하게 합니다. 인자를 사용하는대 있어 세가지 조건을 파악해야하는 상황이 되는대, 직관적으로 이해하기가 힘듭니다. 주석을 봐야 알 수 있는 내용 되버려서요.
UNSET 이라는 컨샙을 bool 인자로 추가하는게 더 나아보이는데 어떻게 생각하시나요?
Collaborator
|
Squash 머지 해주세요~ |
halucinor
pushed a commit
that referenced
this pull request
Aug 24, 2025
* feat(network): Add Subnet, Port, Floating IP tools (#30) * feat(network): Add additional function in network tools (#30) * feat(network): Add neutron tools function unit test (#30) * fix(network): sphinx style comments (#30) * fix(network): refactor code - remove custom raise - remove test case relation removing raise * fix(network): typo change neutron to network (#30) * fix(network): remove unused comments (#30) * fix(network): remove unused allocate floating ip feature (#30) * improve(network): integrating subnet update feature (#30) * improve(network): integrating port update feature (#30) * improve(network): integrating port update feature (#30) * fix(network): alignment subnet model field (#30) * chore(config): restore config * fix(network): alignment port model field (#30) * feat(network): add clear state arg to methods (#30)
halucinor
deleted the
feat/tool-neutron-function-subnet-port-floating-ip
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Key Changes
[Subnet]
[Port]
[Floating IP]
Related Issues
Additional context
.