Skip to content

Nodeset rabbitmquser finalizer management and status tracking via configmap#1781

Open
lmiccini wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
lmiccini:nodeset_rmqu_finalizer_configmap
Open

Nodeset rabbitmquser finalizer management and status tracking via configmap#1781
lmiccini wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
lmiccini:nodeset_rmqu_finalizer_configmap

Conversation

@lmiccini
Copy link
Contributor

@lmiccini lmiccini commented Jan 27, 2026

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lmiccini
Once this PR has been reviewed and has the lgtm label, please assign rabi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56ac80bd0e7547ad88350eb0206886b5

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 31s
adoption-standalone-to-crc-ceph-provider FAILURE in 3h 01m 55s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 51m 23s
openstack-operator-docs-preview POST_FAILURE in 2m 32s

@stuggi stuggi requested a review from slagle January 28, 2026 08:13
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db62c9cd33b34a538c7eccf243769b6a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 56s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 03s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 46m 57s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 34m 08s
openstack-operator-docs-preview POST_FAILURE in 3m 15s

Add dataplane-specific logic to track and manage RabbitMQ user
finalizers for OpenStackDataPlaneNodeSet services. This includes:

- Service finalizer tracking in NodeSet status
- RabbitMQ user creation and cleanup logic
- Multi-cluster RabbitMQ support
- Comprehensive tests for finalizer management

This preserves the webhooks_warnings approach for webhook defaulting
and services controllers while adding only the dataplane-specific
RabbitMQ finalizer management functionality.
@lmiccini lmiccini force-pushed the nodeset_rmqu_finalizer_configmap branch 2 times, most recently from 3885c4a to c1fe8f8 Compare February 7, 2026 18:56
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b5d3972863e64857b2da5055f867ef55

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 41s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 22s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 05m 30s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 43m 01s
✔️ openstack-operator-docs-preview SUCCESS in 3m 14s

@lmiccini
Copy link
Contributor Author

lmiccini commented Feb 8, 2026

/retest

@lmiccini
Copy link
Contributor Author

lmiccini commented Feb 8, 2026

recheck

@lmiccini
Copy link
Contributor Author

lmiccini commented Feb 8, 2026

/test openstack-operator-build-deploy-kuttl-4-18

Update GetNovaCellRabbitMqUserFromSecret to use the new rabbitmq_user_name
field directly when available (nova-operator PR openstack-k8s-operators#1066), with fallback to
parsing transport_url for backwards compatibility.

Add GetNovaCellNotificationRabbitMqUserFromSecret to extract the notification
RabbitMQ user name from the notification_rabbitmq_user_name field.

This simplifies RabbitMQ user tracking and eliminates the need for complex
transport URL parsing when using nova-operator with PR openstack-k8s-operators#1066 or later.

Prepares openstack-operator to work with:
- nova-operator PR openstack-k8s-operators#1066: Propagate rabbitmq users to nova-cellX secret
@lmiccini lmiccini force-pushed the nodeset_rmqu_finalizer_configmap branch from c1fe8f8 to cbfbb7c Compare February 8, 2026 14:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2026

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 1698305 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lmiccini lmiccini force-pushed the nodeset_rmqu_finalizer_configmap branch from cbfbb7c to f52529a Compare February 8, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants