Add labels for the lightspeed-app-server service#30
Conversation
8925a28 to
4d11a08
Compare
4d11a08 to
8b92f4d
Compare
lpiwowar
left a comment
lpiwowar
left a comment
There was a problem hiding this comment.
/lgtm
IIUC how it ties in with the PR in telemetry-operator, then LGTM in my opinion. 👍
Just small nit:
- the commit message could be a tiny bit more descriptive IMO and
- could follow the 50 / 72 rule.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jancervenka, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold We probably want to wait for the telemetry-operator PR to get resolved first and we do not want accidentally block the MCP PR 🙈 . But the development on the PR can continue:) |
|
Yeah it /lgtm me as well! @lpiwowar the PR for telemetry is now merged |
telemetry-operator creates a ScrapeConfig that collects metrics from Lightspeed /metrics endpoint. The ScrapeConfig uses a LabelSelector to discover the Lightspeed service. Adding "metrics" and "service" labels allows the Lightspeed service to be discoverable by the ScrapeConfig.
|
Thank you! I updated the commit message 👍 @lpiwowar |
7da2d03 to
b3c9282
Compare
|
/retest |
|
/lgtm Thank you @jancervenka ! 👍 I'm not sure what to do about the |
|
yes, sounds good! |
3 participants
Add labels for the lightspeed-app-server service that allows it to be discovered by metrics ScrapeConfig