[set_openstack_containers] Fix default ironic python agent image name

[sathlan]

To get a match we need RELATED_IMAGE_ prefix in the default for the
ironic python agent.

Signed-off-by: Sofer Athlan-Guyot sathlang@redhat.com

Closes: OSPCIX-1167

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eshulman2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sathlan]

Validation

When using that patch with #3627 we create /home/zuul/ci-framework-data/artifacts/update_env_vars.sh that has the IRONIC_PYTHON_AGENT_IMAGE transformation:

[zuul@controller-0 ~]$ grep RELATED_IMAGE_IRONIC_PYTHON_AGENT_IMAGE_URL_DEFAULT /home/zuul/ci-framework-data/artifacts/update_env_vars.sh
   | jq '(.spec.install.spec.deployments[]?.spec.template.spec.containers[]?.env[]? | select(.name=="RELATED_IMAGE_IRONIC_PYTHON_AGENT_IMAGE_URL_DEFAULT"?)) |= (.value="images.paas.redhat.com/podified-rhos18-rhel9/ironic-python-agent:258bdd2f6d76a7a05936d0c4841120f9")' \

The generated name look good:

images.paas.redhat.com/podified-rhos18-rhel9/ironic-python-agent:258bdd2f6d76a7a05936d0c4841120f9

which is similar to what we have in a deployment only job:

images.paas.redhat.com/podified-rhos18-rhel9/ironic-python-agent:ac6d012b643ea5db00aaa3313b00e141

Then in the csv of the openstack-operator we have:

                - name: RELATED_IMAGE_IRONIC_PYTHON_AGENT_IMAGE_URL_DEFAULT
                  value: images.paas.redhat.com/podified-rhos18-rhel9/ironic-python-agent:258bdd2f6d76a7a05936d0c4841120f9

which eventually leads to a OpenStackControlPlane with that definition:

    ironicPythonAgentImage: images.paas.redhat.com/podified-rhos18-rhel9/ironic-python-agent:258bdd2f6d76a7a05936d0c4841120f9

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13451333e49441fda73b5879ce2856a0

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 44s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 58m 19s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 36s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 26s
❌ cifmw-molecule-set_openstack_containers FAILURE in 23m 50s