[ci_gen_kustomize_values] Skip startingCSV when deployment version is "latest"#3657
Open
rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
[ci_gen_kustomize_values] Skip startingCSV when deployment version is "latest"#3657rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… "latest" Add "latest" to the exclusion list in OLM values templates to prevent generating an invalid startingCSV field. When cifmw_ci_gen_kustomize_values_deployment_version is set to "latest", the openstack-operator-version field is now skipped, allowing OLM to automatically select the latest CSV from the channel. This fixes ConstraintsNotSatisfiable errors caused by OLM trying to find a CSV literally named "latest" which doesn't exist. Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
force-pushed
the
update-templates
branch
from
f0354b6 to
edb8b89
Compare
Contributor
|
Sounds good to me. Let's wait for job results. |
Contributor
Author
|
The patch worked, but isn't enough to get the issue done. We also need openstack-k8s-operators/architecture#690 But since both of these patches are quite critical, i'm going to test them with other scenarios rather then the upgrade one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #3653
Add "latest" to the exclusion list in OLM values templates to prevent generating an invalid startingCSV field. When
cifmw_ci_gen_kustomize_values_deployment_versionis set to "latest", the openstack-operator-version field is now skipped, allowing OLM to automatically select the latest CSV from the channel.This fixes ConstraintsNotSatisfiable errors caused by OLM trying to find a CSV literally named "latest" which doesn't exist.