[os_must_gather] Add exit rc to os-must-gather main task#3643
[os_must_gather] Add exit rc to os-must-gather main task#3643evallesp wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| echo "The must gather command did not finish on time!" | ||
| echo "{{ shell_cmd_timeout }} seconds was not enough to finish the task." | ||
| fi | ||
| exit $rc |
There was a problem hiding this comment.
I like that improvement. In rescue block, we can check if it gets 124, and if yes, can do must-gather without SOS. I suggest to not execute similar command if exit code was e.g. 1 or 3.
There was a problem hiding this comment.
ack, moving to draft! thanks!!
There was a problem hiding this comment.
I've just added that when clause to the oc adm must-gather command.
Still maintaining the rest of the rescue block without that when clause.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13b13b3cca114b689ce68b1c964b9265 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 06s |
With this we allow to run the rescue block. Previously any timeout in the main task would return the code from the echo which was always success. Also, we're removing from the rescue block the always block. And we've create a always section for finding existing os-must-gather directories and the symlink creation. Also we've changed the dest-dir for the generic fallback command to match the same folder of the symlink. Finally, we've parametriced SOS_EDPM as cifmw_os_must_gather_sos_edpm and we've added default value to "all" Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
os-must-gather-return-error
branch
from
38aa2f1 to
9556cac
Compare
2 participants
With this we allow to run the rescue block. Previously any timeout in the main task would return the code from the echo which was always success.
Also, we're removing from the rescue block the always block. And we've create a always section for finding existing os-must-gather directories and the symlink creation.
Also we've changed the dest-dir for the generic fallback command to match the same folder of the symlink.
Finally, we've parametriced SOS_EDPM as cifmw_os_must_gather_sos_edpm and we've added default value to "all"