Skip to content

[update] Possibility to activate kpatch during update.#3377

Open
sathlan wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
sathlan:update-kpatch
Open

[update] Possibility to activate kpatch during update.#3377
sathlan wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
sathlan:update-kpatch

Conversation

@sathlan
Copy link
Contributor

@sathlan sathlan commented Oct 7, 2025

By setting cifmw_update_openstack_update_kpatch to true, one can have
the edmp kpatch code turn on.

Depends-On: openstack-k8s-operators/install_yamls#1098

@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1098 is needed.

@github-actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 25, 2025
@github-actions github-actions bot closed this Nov 1, 2025
@sathlan sathlan reopened this Dec 2, 2025
@sathlan sathlan added python Pull requests that update Python code do-not-merge/hold and removed Stale python Pull requests that update Python code labels Dec 2, 2025
@sathlan sathlan marked this pull request as draft December 2, 2025 09:15
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1098 is needed.

@github-actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3377,9f36cdb14fe3c2d9c887ee5b4a0dc33aac03b00e

By setting cifmw_update_openstack_update_kpatch to true, one can have
the edmp kpatch code turn on.

Depends-On: openstack-k8s-operators/install_yamls#1098

Signed-off-by: Sofer Athlan-Guyot <sathlang@redhat.com>
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1098 is needed.

@github-actions github-actions bot removed the Stale label Feb 4, 2026
@sathlan sathlan marked this pull request as ready for review February 4, 2026 11:06
@sathlan sathlan self-assigned this Feb 4, 2026
@sathlan
Copy link
Contributor Author

sathlan commented Feb 4, 2026

Validation: Code Working as Expected.

Given this zuul definition snippet:

- job:
    name: periodic-podified-multinode-update-rhel9-osp18-crc-kpatch
    parent: periodic-podified-multinode-update-rhel9-osp18-crc
    vars:
      cifmw_update_openstack_update_kpatch: true

where we set cifmw_update_openstack_update_kpatch: true then this code correctly sets the KPATCH flag down to install_yamls:

In this test job main output job-output.txt.gz

We can see:

2026-02-03 14:08:49.967765 | controller | TASK [install_yamls_makes : Debug make_openstack_update_run_params var=make_openstack_update_run_params] ***
2026-02-03 14:08:49.967770 | controller | Tuesday 03 February 2026  14:08:49 +0000 (0:00:00.068)       0:03:18.979 ******
2026-02-03 14:08:49.967775 | controller | Tuesday 03 February 2026  14:08:49 +0000 (0:00:00.068)       0:03:18.978 ******
2026-02-03 14:08:50.032575 | controller | ok: [localhost] =>
2026-02-03 14:08:50.032604 | controller |     make_openstack_update_run_params:
2026-02-03 14:08:50.032611 | controller |       KPATCH_UPDATE: true
2026-02-03 14:08:50.032617 | controller |       OPENSTACK_VERSION: 0.0.2
2026-02-03 14:08:50.032622 | controller |       TIMEOUT: 600s
2026-02-03 14:08:50.032627 | controller |

Then in this comment from the install_yaml PR we can see that install_yamls consumes that correctly.

@holser holser self-requested a review February 5, 2026 18:30
@holser
Copy link
Contributor

holser commented Feb 5, 2026

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: holser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants