Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anpingli The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
cc @etmurasaki |
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const report_dir = process.env.ARTIFACT_DIR || '/tmp'; | ||
|
|
There was a problem hiding this comment.
missing import registerCypressGrep from '@cypress/grep/src/plugin'; to resolve tags problem on e2e files
web/cypress/e2e/acceptance.cy.ts
Outdated
| @@ -0,0 +1,104 @@ | |||
| import * as dataTest from '../fixtures/data-test' | |||
There was a problem hiding this comment.
I know the challenge you mentioned during COO UI Testing call about locators on Troub Panel. I believe data-test file should be used to store classes, bc we intend to include PF6 on COO1.5.0 and it will be much easier to maintain the testing files later.
There was a problem hiding this comment.
Thanks for explaining. I have added the classed element in data-test.txt.
There was a problem hiding this comment.
all these elements are related to monitoring-plugin and I believe you should only the ones used in your test
There was a problem hiding this comment.
Yes. I'd like to re-use these elements. I will add more troubleshoot and Logging elements and Consider backporting to monitoring-plugin someday.
| }); | ||
|
|
||
| // Execute the waitUntil with the original options (without timeoutMessage) | ||
| return cy.waitUntil(fn, waitOptions); |
There was a problem hiding this comment.
I don't call this command. I will cherry-pick the fix from the monitor-plugin someday.
openshift-merge-robot
added
the
needs-rebase
anpingli
force-pushed
the
web-test
branch
2 times, most recently
from
6a5b5e6 to
809e3ea
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
@anpingli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
My the first cypress automation cases.
Prerequisite: The Troubleshoot panel plugin must be enabled.
Execution：
make test-e2e