Skip to content

config: add CAPZ e2e integration job to aro-integration#3688

Draft
RadekCap wants to merge 1 commit into
openshift:mainfrom
RadekCap:capz-e2e-integration-sippy
Draft

config: add CAPZ e2e integration job to aro-integration#3688
RadekCap wants to merge 1 commit into
openshift:mainfrom
RadekCap:capz-e2e-integration-sippy

Conversation

@RadekCap

@RadekCap RadekCap commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add periodic-ci-Azure-ARO-HCP-main-capz-e2e-integration to the aro-integration release in openshift-customizations.yaml
  • This makes the new ARO-HCP CAPZ e2e integration workflow visible in Sippy's integration dashboard
  • The job was added in openshift/release#81015 and runs weekdays at 20:00 UTC

Jira: ARO-27714

Test plan

  • Verify job appears in the aro-integration dashboard after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Expanded automated validation coverage with an additional periodic integration job for OpenShift deployments.

Jira: ARO-27714

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2026
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3ece299b-85d7-4592-874d-d41a80d51e35

📥 Commits

Reviewing files that changed from the base of the PR and between 09af781 and 6d0b38b.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml

Walkthrough

Adds one boolean job toggle to the aro-integration job list in config/openshift-customizations.yaml.

Changes

OpenShift integration job toggle

Layer / File(s) Summary
Job toggle update
config/openshift-customizations.yaml
Adds periodic-ci-Azure-ARO-HCP-main-capz-e2e-integration: true under releasesaro-integrationjobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ready-for-human-review

Suggested reviewers

  • deepsm007
  • sosiouxme
🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding the CAPZ e2e integration job to the aro-integration config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR only updates config/openshift-customizations.yaml; no Go code or error-handling paths are changed.
Sql Injection Prevention ✅ Passed PASS: The PR's new SQL uses bind parameters for buildID/startDate/release, and formatted identifiers are hardcoded/trusted; no new user-input concatenation.
Excessive Css In React Should Use Styles ✅ Passed PR only changes config/openshift-customizations.yaml; no React/JSX inline styles are present, so the CSS-style check is not applicable.
Test Coverage For New Features ✅ Passed PASS: The PR only adds a YAML job entry in config/openshift-customizations.yaml, which is config-only and exempt from new test coverage.
Single Responsibility And Clear Naming ✅ Passed Config-only change; no packages, structs, or methods were added, and the new job name is specific and consistent with existing naming.
Feature Documentation ✅ Passed PASS: docs/features only contains the job-analysis-symptoms doc, which is unrelated to adding an aro-integration job in config/openshift-customizations.yaml.
Stable And Deterministic Test Names ✅ Passed Only config/openshift-customizations.yaml changed; it’s YAML job registration, not Ginkgo test code, so no unstable test names were introduced.
Test Structure And Quality ✅ Passed PASS — this PR only adds a YAML job entry in config/openshift-customizations.yaml; no Ginkgo tests or cluster-interaction code were changed.
Microshift Test Compatibility ✅ Passed PR only updates config/openshift-customizations.yaml to add a dashboard job entry; no new Ginkgo tests or MicroShift-unsafe API usage in this repo.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only adds an existing periodic job to config/openshift-customizations.yaml; it introduces no new Ginkgo tests or SNO-sensitive test logic.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds a job entry in config/openshift-customizations.yaml; no deployment manifests, controllers, or scheduling constraints were changed.
Ote Binary Stdout Contract ✅ Passed PASS: PR only adds one YAML job entry in config/openshift-customizations.yaml; no process-level binary code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Config-only change: it adds a job name to config/openshift-customizations.yaml, with no new Ginkgo e2e test code or network assumptions.
No-Weak-Crypto ✅ Passed Only change is a YAML job entry; no weak-crypto terms, custom crypto, or secret/token comparisons were present.
Container-Privileges ✅ Passed Only a Sippy config entry was added; no container/K8s manifests or privilege settings were introduced outside vendor files.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds a job name to a YAML config overlay; no logging code or sensitive data exposure is introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RadekCap
Once this PR has been reviewed and has the lgtm label, please assign deepsm007 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant