Skip to content

Add external OIDC (Keycloak) console e2e jobs for console and console-operator - #84975

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:console-external-oidc-jobs
Open

redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:console-external-oidc-jobs

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a manually-triggered CI job, e2e-aws-external-oidc-console, to both openshift/console and openshift/console-operator. Each job launches an IPI AWS cluster with in-cluster Keycloak and external OIDC configured, then runs the console e2e suite against it, using the existing step-registry workflow idp-external-oidc-keycloak-aws (already used by cluster-authentication-operator).

Changes

Config edits:

  • ci-operator/config/openshift/console/openshift-console-main.yaml — new e2e-aws-external-oidc-console test (always_run: false, optional: true), workflow: idp-external-oidc-keycloak-aws, Playwright test override matching the existing e2e-gcp-console conventions (from: console-playwright-runner, console-plugin-demo dependency).
  • ci-operator/config/openshift/console-operator/openshift-console-operator-main.yaml — new e2e-aws-external-oidc-console test (always_run: false, optional: true), workflow: idp-external-oidc-keycloak-aws, override matching the existing e2e-aws-console conventions (from: stable:console-tests).

Generated files (via make ci-operator-config + make jobs):

  • ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yaml
  • ci-operator/jobs/openshift/console-operator/openshift-console-operator-main-presubmits.yaml

Triggering

Both jobs are always_run: false / optional: true — they run only on demand via:

/test e2e-aws-external-oidc-console

and do not block merges.

Notes

The companion console-repo changes that make the e2e suite OIDC-aware (Keycloak login flow, credential plumbing) are in openshift/console#17162.

Generators (make ci-operator-config, make jobs) ran cleanly; committed config + generated job YAML together.


AI-generated. Review for accuracy.

@jhadvig requested via Chai Bot

Summary by CodeRabbit

  • Adds optional, manually triggered e2e-aws-external-oidc-console CI jobs for openshift/console and openshift/console-operator.
  • The jobs create AWS IPI clusters with external OIDC and in-cluster Keycloak, then run the console e2e suite through idp-external-oidc-keycloak-aws.
  • Developers can start the jobs with /test e2e-aws-external-oidc-console.
  • Updates the CI configuration, generated Prow job definitions, and Playwright test overrides.

@openshift-ci
openshift-ci Bot requested review from jhadvig and rhamilto September 11, 2026 09:57
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 211c31e9-0aea-40c4-a7a2-bae6637a3157

📥 Commits

Reviewing files that changed from the base of the PR and between 1294b7e and 9ed807c.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/console/openshift-console-main.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The CI configuration adds optional AWS external OIDC console e2e jobs for the console and console-operator components. The jobs use the external OIDC Keycloak workflow and define component-specific images, resources, and timeouts.

Changes

AWS external OIDC e2e coverage

Layer / File(s) Summary
Configure AWS external OIDC jobs
ci-operator/config/openshift/console/openshift-console-main.yaml, ci-operator/config/openshift/console-operator/openshift-console-operator-main.yaml
Adds optional AWS e2e jobs using the idp-external-oidc-keycloak-aws workflow. The jobs define their test images, dependencies, resource requests, cluster profile, and timeouts.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to 9ed80

The optional AWS external OIDC CI jobs are consistently configured and introduce no confirmed merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding external OIDC Keycloak console end-to-end jobs for both console and console-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI configuration and generated presubmit YAML files. The added entries define the static CI job name e2e-aws-external-oidc-console and invoke existing scripts. No Ginkgo It, `D…
Test Structure And Quality ✅ Passed PASS: The PR changes only four YAML CI configuration/generated presubmit files. The added content defines optional jobs and invokes existing test-prow-e2e.sh; it adds no Ginkgo test code, It block…
Microshift Test Compatibility ✅ Passed PASS: The authoritative PR diff changes only four CI YAML files. It adds presubmit job definitions and generated configuration that invoke existing console e2e scripts; it adds no Ginkgo test source o…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only four YAML CI configuration files. The diff adds CI jobs that invoke existing console e2e scripts and the idp-external-oidc-keycloak-aws workflow; it adds no Ginkg…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The PR changes only CI operator test configuration and generated Prow presubmit YAML. The new entries select an AWS cluster profile and an existing OIDC workflow; they do not modify deployment …
Ote Binary Stdout Contract ✅ Passed The reviewed range changes only four YAML configuration and generated presubmit files. The additions define jobs that invoke existing test-prow-e2e.sh commands and the existing `idp-external-oidc-ke…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request changes only four YAML CI configuration/generated-job files. It adds no Ginkgo test code or network logic. The jobs invoke the existing test-prow-e2e.sh suite and the existin…
No-Weak-Crypto ✅ Passed The pull request changes only four CI YAML files. The added content defines optional jobs and generated Prow entries; it adds no cryptographic algorithm, crypto implementation, or secret/token compari…
Container-Privileges ✅ Passed The pull request adds two optional CI jobs and their generated presubmit Pod specs. The added YAML contains no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, `allowPrivilegeEsca…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds CI job definitions only. The added commands invoke existing e2e scripts and the existing idp-external-oidc-keycloak-aws workflow. The changed lines contain no logging statement…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…-operator

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@redhat-chai-bot
redhat-chai-bot force-pushed the console-external-oidc-jobs branch from 1294b7e to 9ed807c Compare September 18, 2026 02:55
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-console-main-e2e-aws-external-oidc-console openshift/console presubmit Presubmit changed
pull-ci-openshift-console-operator-main-e2e-aws-external-oidc-console openshift/console-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant