Skip to content

Disable 5.0 ipsec 120/252 node jobs and add ipsec 24-node job - #83216

Open
mohit-sheth wants to merge 1 commit into
openshift:mainfrom
mohit-sheth:disable-5.0-ipsec-large-add-24nodes
Open

Disable 5.0 ipsec 120/252 node jobs and add ipsec 24-node job#83216
mohit-sheth wants to merge 1 commit into
openshift:mainfrom
mohit-sheth:disable-5.0-ipsec-large-add-24nodes

Conversation

@mohit-sheth

@mohit-sheth mohit-sheth commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • control-plane-ipsec-120nodes: disable (set always_run: false)
  • control-plane-ipsec-252nodes: disable (set always_run: false)
  • control-plane-ipsec-24nodes: new 24-node ipsec job on aws-perfscale, 2x/month (11th, 23rd), based on the 120-node config adapted for small scale

All changes in the 5.0 nightly config only.

@openshift-ci
openshift-ci Bot requested review from pruan-rht and psalajova August 10, 2026 23:18
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mohit-sheth, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e64aa5ec-6947-464f-a6d7-63451b0536da

📥 Commits

Reviewing files that changed from the base of the PR and between add2700 and 9a99edc.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.0-nightly-x86.yaml

Walkthrough

The AWS 5.0 nightly configuration adds a scheduled 24-node control-plane IPsec job. It disables automatic execution for the existing 120-node and 252-node IPsec jobs.

Changes

AWS PerfScale IPsec scheduling

Layer / File(s) Summary
IPsec job schedule updates
ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.0-nightly-x86.yaml
Adds the scheduled 24-node AWS OVN IPsec job and sets the 120-node and 252-node jobs to always_run: false.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: redhat-chai-bot


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The new scheduled job invokes openshift-qe-workers-scale, whose set -x traces /secret credentials, ROSA tokens, and the credential-bearing ES_SERVER URL. Disable shell tracing before reading or using secrets, pass credentials through protected mechanisms, and ensure logs redact secret-bearing URLs and command arguments.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only YAML job definitions and generated Prow YAML; no Ginkgo It(), Describe(), Context(), or When() test title is added or modified.
Test Structure And Quality ✅ Passed The PR changes only CI YAML configuration files; no Ginkgo test code or It blocks were added or modified, so these test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The pull request changes only three YAML CI configuration files and adds no Ginkgo test declarations or test source requiring MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only CI YAML configuration and generated job definitions; it adds no Ginkgo e2e tests or test source requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only ci-operator test/Prow job YAML. It adds no deployment, operator, controller, or topology-sensitive scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The parent diff changes only one YAML job configuration; it adds scheduling and workflow fields and contains no OTE process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only the 5.0 nightly YAML and adds a CI job configuration; it adds no Ginkgo tests or test code requiring IPv4 or external connectivity.
No-Weak-Crypto ✅ Passed The commit adds and disables scheduled IPsec jobs only; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons appear in changed files.
Container-Privileges ✅ Passed The changed CI job configuration and referenced step definitions contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes disabling the 120-node and 252-node jobs and adding the 24-node job.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohit-sheth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@mohit-sheth

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
ADDITIONAL_WORKER_NODES: "21"
BASE_DOMAIN: perfscale.devcluster.openshift.com
ENABLE_LAYER_3: "false"
KB_FLAGS: --local-indexing

@afcollins afcollins Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync up flags from 120node job (CD_V2_EXTRA_FLAGS, KB_FLAGS, NODE_DENSITY_GC)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mohit-sheth, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto add2700e8094fb4f28ab9e0570d00663833fd646 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mohit-sheth
mohit-sheth force-pushed the disable-5.0-ipsec-large-add-24nodes branch from 5f03a7f to 0ced526 Compare August 10, 2026 23:57
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2026
- control-plane-ipsec-120nodes: disable (set always_run: false)
- control-plane-ipsec-252nodes: disable (set always_run: false)
- control-plane-ipsec-24nodes: new 24-node ipsec job on aws-perfscale,
  2x/month (11th, 23rd), with flags synced from the 120-node job

Assisted-by: Claude
Signed-off-by: Mohit Sheth <msheth@redhat.com>
@mohit-sheth
mohit-sheth force-pushed the disable-5.0-ipsec-large-add-24nodes branch from 0ced526 to 9a99edc Compare August 10, 2026 23:58
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mohit-sheth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mohit-sheth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@mohit-sheth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants