Skip to content

WIP: dns: add paas.redhat.com to intranet forward zones - #83112

Open
fracappa wants to merge 2 commits into
openshift:mainfrom
fracappa:fca/dns-add-paas-redhat-zone
Open

WIP: dns: add paas.redhat.com to intranet forward zones#83112
fracappa wants to merge 2 commits into
openshift:mainfrom
fracappa:fca/dns-add-paas-redhat-zone

Conversation

@fracappa

@fracappa fracappa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

MicroShift crypto scanner needs to pull images from images.paas.redhat.com, which requires intranet DNS resolution

Summary by CodeRabbit

  • Adds paas.redhat.com to the rh-intranet DNS forward zones.
  • Enables MicroShift crypto scanner jobs to resolve images.paas.redhat.com and pull required images.
  • Documents the intranet access requirement for the MicroShift rebase and crypto scan step.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@fracappa, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a07659c8-4f2f-4e12-abba-596bfde472db

📥 Commits

Reviewing files that changed from the base of the PR and between 88ce08f and 1dbddb8.

📒 Files selected for processing (2)
  • ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-ref.yaml
  • clusters/build-clusters/build-shared/managed/dns.yaml

Walkthrough

The managed DNS configuration adds paas.redhat.com to the rh-intranet server zone list. The MicroShift crypto-scan documentation records its intranet access requirement.

Changes

Intranet DNS and scan documentation

Layer / File(s) Summary
Add intranet DNS zone and requirement documentation
clusters/build-clusters/build-shared/managed/dns.yaml, ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-ref.yaml
The rh-intranet server now includes the paas.redhat.com DNS zone. The MicroShift crypto-scan documentation states that intranet access is required for images.paas.redhat.com.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • openshift/release#82024: Adds DNS resolution and documentation for images.paas.redhat.com in the MicroShift crypto-scan workflow.

Suggested reviewers: droslean, jmguzik

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding paas.redhat.com to the intranet forward zones.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes DNS YAML and step documentation only; the parent-to-HEAD diff adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The PR changes only two YAML configuration entries; the full two-commit diff adds no Ginkgo tests or test code, so these test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only two YAML files and adds no Go files or Ginkgo tests, so MicroShift test compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only DNS and step documentation YAML; it adds no Ginkgo e2e tests or multi-node assumptions, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The actual patch changes only CI step documentation; it adds no deployment, controller, replica, affinity, topology spread, selector, toleration, or PDB scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR range changes only two YAML files: DNS zone data and step documentation; it adds no OTE binary code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The change adds only DNS YAML and step documentation; it adds no Ginkgo e2e test or test code requiring IPv4 or public connectivity.
No-Weak-Crypto ✅ Passed The two PR commits add only paas.redhat.com to DNS and an intranet-access documentation line; they add no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or crypto implementation.
Container-Privileges ✅ Passed The two changed lines add a DNS zone and documentation only; the aggregate PR diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds a DNS zone and documentation only. It adds no logging or output statements, and the existing command logging is unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from droslean and jmguzik August 7, 2026 16:04
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2026
@fracappa

fracappa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@fracappa: no rehearsal-relevant files were changed in this PR

@fracappa

fracappa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@fracappa: no rehearsal-relevant files were changed in this PR

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fracappa
Once this PR has been reviewed and has the lgtm label, please assign danilo-gemoli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2026
@fracappa

fracappa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@fracappa
fracappa force-pushed the fca/dns-add-paas-redhat-zone branch from 52918fe to 1dbddb8 Compare August 7, 2026 16:46
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@fracappa: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-test-rebase openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-5.0-test-rebase openshift/microshift presubmit Registry content changed
periodic-ci-openshift-microshift-release-5.1-periodics-rebase-on-nightlies N/A periodic Registry content changed
periodic-ci-openshift-microshift-release-5.0-periodics-rebase-on-nightlies N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@fracappa

fracappa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@fracappa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant